Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirque reachable calibration aide #22803

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

JohSchneider
Copy link
Contributor

Description

the physical reachable range for the x/y axis can be user defined with CIRQUE_PINNACLE_X_LOWER etc,
to figure out these values the new CIRQUE_PINNACLE_REACHABLE_CALIBRATION can be used.

a user can enable the debug console, this feature, dandomly move over the sensor to cover the whole area and then read the last min/max value set printed to the console to set those defines

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@JohSchneider JohSchneider changed the base branch from master to develop January 1, 2024 15:12
@github-actions github-actions bot added core keyboard keymap documentation via Adds via keymap and/or updates keyboard for via support dd Data Driven Changes and removed keyboard keymap via Adds via keymap and/or updates keyboard for via support dd Data Driven Changes labels Jan 1, 2024
the physical reachable range for the x/y axis can be user defined with `CIRQUE_PINNACLE_X_LOWER` etc, to figure ut these values the new `CIRQUE_PINNACLE_REACHABLE_CALIBRATION` can be used.
@JohSchneider JohSchneider force-pushed the cirque_reachable_calibration_aide branch from afecd9b to 3c27afb Compare January 2, 2024 04:27
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM except for a small nit.

drivers/sensors/cirque_pinnacle.c Outdated Show resolved Hide resolved
@KarlK90 KarlK90 requested review from daskygit, drashna and a team January 10, 2024 16:41
@JohSchneider JohSchneider requested a review from KarlK90 January 10, 2024 17:28
@KarlK90 KarlK90 requested a review from a team January 12, 2024 19:04
@drashna drashna merged commit 6b52c6d into qmk:develop Jan 13, 2024
3 checks passed
@JohSchneider JohSchneider deleted the cirque_reachable_calibration_aide branch January 13, 2024 11:37
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Co-authored-by: Stefan Kerkmann <[email protected]>
Co-authored-by: Johannes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants