-
-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding standard keymap for wave keyboard to fix #22695 #22741
Adding standard keymap for wave keyboard to fix #22695 #22741
Conversation
This keymap was deleted by qmk#22695 .
Mod-tap keys are permitted in the default keymap. |
The keymap also features:
Would that all be accepted for the default keymap? Initially, this is why I offered a |
Self hosted userspace might be the right place for feature rich keymaps: #22724 |
My understanding is that the only feature in this list which would not be allowed is the combos. |
Thank you for the link, this is something new. #22724 mentions vendor keymaps; I believe I classify as a vendor since I am the creator/maintainer/designer of this keyboard. I would like to offer a fully featured, usable keymap to everyone who either buys or builds my keyboard. |
If that is the case, then I guess that by setting this keymap as the default one, I wouldn't be straying really far from the rules. I will try to replace the combos by something else if possible. |
Hello! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keyboard updates need to go through develop
.
To make sure I understand, I am to merge this PR into the |
Yes.
|
Description
The wave keyboard had a
feature
keymap which was truly ready to use, but it was deleted by #22695 . I am therefore adding it once again, this time as thestandard
keymap to be coherent with the naming conventions.This
standard
keymap is needed on top of thedefault
one because thedefault
keymap cannot use special features (such as home-row mods) which make a 36 key keyboard truly usable.Types of Changes
Checklist