[keyboard]Graystudio BD60 Support #22210

edwardslau · 2023-10-05T17:36:32Z

Description

Graystudio BD60 PCB Firmware

Types of Changes

Enhancement/optimization
Keyboard (addition or update)
Keymap/layout/userspace (addition or update)

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
I have read the CONTRIBUTING document.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/gray_studio/bd60/rules.mk

keyboards/gray_studio/bd60/config.h

zvecr · 2023-10-05T22:05:17Z

keyboards/gray_studio/bd60/info.json

+        "device_version": "0.0.1",
+    },
+    "features": {
+        "backlight": false,


Suggested change

"backlight": false,

This still needs removing

keyboards/gray_studio/bd60/readme.md

keyboards/gray_studio/bd60/bd60.c

keyboards/gray_studio/bd60/info.json

Co-authored-by: Joel Challis <[email protected]>

keyboards/gray_studio/bd60/info.json

keyboards/gray_studio/bd60/keymaps/via/keymap.c

keyboards/gray_studio/bd60/keymaps/default/keymap.c

keyboards/gray_studio/bd60/readme.md

keyboards/gray_studio/bd60/rules.mk

Co-authored-by: Duncan Sutherland <[email protected]>

keyboards/gray_studio/bd60/readme.md

keyboards/gray_studio/bd60/info.json

Co-authored-by: Duncan Sutherland <[email protected]>

keyboards/gray_studio/bd60/info.json

Co-authored-by: Duncan Sutherland <[email protected]>

keyboards/gray_studio/bd60/keymaps/default/keymap.c

keyboards/gray_studio/bd60/keymaps/via/keymap.c

Co-authored-by: Duncan Sutherland <[email protected]>

dunk2k · 2023-12-31T11:16:00Z

keyboards/gray_studio/bd60/info.json

4th/Shift row has an extra key (typically ISO Backslash); please remove and correct matrix co-ordinates for remaining keys in said row.

Co-authored-by: Duncan Sutherland <[email protected]>

…irmware into graystudio-bd60

fauxpark · 2024-01-14T20:11:00Z

keyboards/gray_studio/bd60/info.json

Please run qmk format-json -i on this file.

This is still outstanding, and just to note, there is no need to continually merge master.

Still outstanding, and this file should also be renamed to keyboard.json.

zvecr · 2024-01-17T16:12:21Z

keyboards/gray_studio/bd60/config.h

This file should still be removed.

keyboards/gray_studio/bd60/info.json

Co-authored-by: Joel Challis <[email protected]>

zvecr · 2024-02-01T02:46:38Z

keyboards/gray_studio/bd60/info.json

+        "device_version": "0.0.1",
+    },
+    "features": {
+        "backlight": false,


This still needs removing

zvecr · 2024-02-01T02:47:29Z

keyboards/gray_studio/bd60/config.h

This file still needs to be removed

tzarc · 2024-08-26T10:34:32Z

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

keyboards/gray_studio/bd60/info.json

dunk2k · 2024-09-02T19:19:02Z

keyboards/gray_studio/bd60/info.json

+    "community_layouts": [
+        "60_ansi",
+        "60_ansi_split_bs_rshift",
+        "60_ansi_tsangan",
+        "60_tsangan_hhkb",
+        "60_ansi_wkl",
+        "60_ansi_wkl_split_bs_rshift",
+        "60_hhkb"
+    ],


make array literal a one liner

tsangan_hhkb -> ansi_tsangan_split_bs_rshift

Suggested change

"community_layouts": [

"60_ansi",

"60_ansi_split_bs_rshift",

"60_ansi_tsangan",

"60_tsangan_hhkb",

"60_ansi_wkl",

"60_ansi_wkl_split_bs_rshift",

"60_hhkb"

],

"community_layouts": ["60_ansi", "60_ansi_split_bs_rshift", "60_ansi_tsangan", "60_ansi_tsangan_split_bs_rshift", "60_ansi_wkl", "60_ansi_wkl_split_bs_rshift", "60_hhkb"],

github-actions · 2024-10-18T02:02:59Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

fauxpark · 2024-10-18T02:08:02Z

keyboards/gray_studio/bd60/keymaps/via/keymap.c

VIA keymap needs to be removed.

fauxpark · 2024-10-18T02:08:42Z

keyboards/gray_studio/bd60/bd60.c

+const rgblight_segment_t PROGMEM my_capslock_layer[] = RGBLIGHT_LAYER_SEGMENTS(
+    {0,1, HSV_WHITE}
+);     
+const rgblight_segment_t* const PROGMEM my_rgb_layers[] = RGBLIGHT_LAYERS_LIST(
+    my_capslock_layer
+);
+
+void keyboard_post_init_kb(void) {
+    // Enable the LED layers
+    rgblight_layers = my_rgb_layers;
+
+    keyboard_post_init_user();
+}
+
+bool led_update_kb(led_t led_state) {
+    if (led_update_user(led_state)) {
+        rgblight_set_layer_state(0, led_state.caps_lock);
+    }
+    return true;
+}


Suggested change

const rgblight_segment_t PROGMEM my_capslock_layer[] = RGBLIGHT_LAYER_SEGMENTS(

{0,1, HSV_WHITE}

);

const rgblight_segment_t* const PROGMEM my_rgb_layers[] = RGBLIGHT_LAYERS_LIST(

my_capslock_layer

);

void keyboard_post_init_kb(void) {

// Enable the LED layers

rgblight_layers = my_rgb_layers;

keyboard_post_init_user();

}

bool led_update_kb(led_t led_state) {

if (led_update_user(led_state)) {

rgblight_set_layer_state(0, led_state.caps_lock);

}

return true;

}

#ifdef RGBLIGHT_LAYERS

const rgblight_segment_t PROGMEM my_capslock_layer[] = RGBLIGHT_LAYER_SEGMENTS(

{0,1, HSV_WHITE}

);

const rgblight_segment_t* const PROGMEM my_rgb_layers[] = RGBLIGHT_LAYERS_LIST(

my_capslock_layer

);

void keyboard_post_init_kb(void) {

// Enable the LED layers

rgblight_layers = my_rgb_layers;

keyboard_post_init_user();

}

bool led_update_kb(led_t led_state) {

if (led_update_user(led_state)) {

rgblight_set_layer_state(0, led_state.caps_lock);

}

return true;

}

#endif

fauxpark · 2024-10-18T02:09:10Z

keyboards/gray_studio/bd60/rules.mk

This file can be deleted.

fauxpark · 2024-10-18T02:09:54Z

keyboards/gray_studio/bd60/keymaps/default/keymap.c

+    ),
+    [1] = LAYOUT_all(
+        _______, KC_F1,   KC_F2,   KC_F3,   KC_F4,   KC_F5,   KC_F6,   KC_F7,   KC_F8,   KC_F9,   KC_F10,  KC_F11,  KC_F12,  _______, _______,
+        _______,          RGB_TOG, RGB_MOD, RGB_HUI, RGB_HUD, RGB_SAI, RGB_SAD, RGB_VAI, RGB_VAD, _______, _______, _______, _______, _______, 


Suggested change

_______, RGB_TOG, RGB_MOD, RGB_HUI, RGB_HUD, RGB_SAI, RGB_SAD, RGB_VAI, RGB_VAD, _______, _______, _______, _______, _______,

_______, UG_TOGG, UG_NEXT, UG_HUEU, UG_HUED, UG_SATU, UG_SATD, UG_VALU, UG_VALD, _______, _______, _______, _______, _______,

fauxpark · 2024-10-18T02:10:36Z

keyboards/gray_studio/bd60/info.json

Still outstanding, and this file should also be renamed to keyboard.json.

github-actions · 2024-12-04T02:09:22Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions · 2025-01-04T02:00:56Z

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

bd60 commit

6fd02f2

github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 5, 2023

zvecr requested changes Oct 5, 2023

View reviewed changes

edwardslau and others added 8 commits October 5, 2023 16:14

Update keyboards/gray_studio/bd60/rules.mk

0fe98f0

Co-authored-by: Joel Challis <[email protected]>

Update keyboards/gray_studio/bd60/config.h

baecf7f

Co-authored-by: Joel Challis <[email protected]>

Update keyboards/gray_studio/bd60/info.json

b9f0cee

Co-authored-by: Joel Challis <[email protected]>

Update keyboards/gray_studio/bd60/readme.md

12fe1a7

Co-authored-by: Joel Challis <[email protected]>

Update keyboards/gray_studio/bd60/readme.md

a74d22d

Co-authored-by: Joel Challis <[email protected]>

Update keyboards/gray_studio/bd60/readme.md

d464491

Co-authored-by: Joel Challis <[email protected]>

Update keyboards/gray_studio/bd60/info.json

caa6da1

Co-authored-by: Joel Challis <[email protected]>

Update keyboards/gray_studio/bd60/bd60.c

3cecb06

Co-authored-by: Joel Challis <[email protected]>

dunk2k suggested changes Oct 6, 2023

View reviewed changes

edwardslau and others added 9 commits October 6, 2023 15:00

Update keyboards/gray_studio/bd60/info.json

e0df197

Co-authored-by: Duncan Sutherland <[email protected]>

Update keyboards/gray_studio/bd60/info.json

d045048

Co-authored-by: Duncan Sutherland <[email protected]>

Update keyboards/gray_studio/bd60/info.json

41bb579

Co-authored-by: Duncan Sutherland <[email protected]>

Update keyboards/gray_studio/bd60/info.json

b7cc70c

Co-authored-by: Duncan Sutherland <[email protected]>

Update keyboards/gray_studio/bd60/keymaps/via/keymap.c

47066c3

Co-authored-by: Duncan Sutherland <[email protected]>

Update keyboards/gray_studio/bd60/rules.mk

f0f37d8

Co-authored-by: Duncan Sutherland <[email protected]>

Update keyboards/gray_studio/bd60/keymaps/default/keymap.c

3ff78c8

Co-authored-by: Duncan Sutherland <[email protected]>

Update info.json

aacb540

Update info.json

c6fd8cb

dunk2k suggested changes Oct 7, 2023

View reviewed changes

keyboards/gray_studio/bd60/readme.md Show resolved Hide resolved

keyboards/gray_studio/bd60/info.json Outdated Show resolved Hide resolved

Update keyboards/gray_studio/bd60/readme.md

7f259c0

Co-authored-by: Duncan Sutherland <[email protected]>

edwardslau requested a review from dunk2k October 7, 2023 16:59

dunk2k suggested changes Oct 7, 2023

View reviewed changes

keyboards/gray_studio/bd60/info.json Outdated Show resolved Hide resolved

Update keyboards/gray_studio/bd60/info.json

688c203

Co-authored-by: Duncan Sutherland <[email protected]>

dunk2k suggested changes Oct 7, 2023

View reviewed changes

keyboards/gray_studio/bd60/keymaps/default/keymap.c Outdated Show resolved Hide resolved

keyboards/gray_studio/bd60/keymaps/via/keymap.c Outdated Show resolved Hide resolved

Update keyboards/gray_studio/bd60/keymaps/default/keymap.c

448c115

Co-authored-by: Duncan Sutherland <[email protected]>

dunk2k suggested changes Dec 31, 2023

View reviewed changes

edwardslau and others added 7 commits January 1, 2024 09:51

Update keyboards/gray_studio/bd60/info.json

b83af1a

Co-authored-by: Duncan Sutherland <[email protected]>

Update keyboards/gray_studio/bd60/info.json

6ff5b16

Co-authored-by: Duncan Sutherland <[email protected]>

Update info.json

2477185

Merge branch 'graystudio-bd60' of https://github.com/edwardslau/qmk_f…

1b816a1

…irmware into graystudio-bd60

Merge branch 'master' into graystudio-bd60

9f5e770

Merge branch 'master' into graystudio-bd60

35e44d3

Merge branch 'master' into graystudio-bd60

936caa6

drashna approved these changes Jan 14, 2024

View reviewed changes

drashna requested a review from a team January 14, 2024 16:42

fauxpark requested changes Jan 14, 2024

View reviewed changes

Merge branch 'master' into graystudio-bd60

d3b3b2e

zvecr requested changes Jan 17, 2024

View reviewed changes

edwardslau and others added 2 commits January 18, 2024 00:16

Update keyboards/gray_studio/bd60/info.json

e831426

Co-authored-by: Joel Challis <[email protected]>

Update keyboards/gray_studio/bd60/info.json

5db90d7

Co-authored-by: Joel Challis <[email protected]>

drashna requested a review from a team February 1, 2024 02:25

drashna added the awaiting review label Feb 1, 2024

zvecr requested changes Feb 1, 2024

View reviewed changes

tzarc removed the awaiting review label Aug 26, 2024

fauxpark reviewed Aug 28, 2024

View reviewed changes

keyboards/gray_studio/bd60/info.json Show resolved Hide resolved

dunk2k suggested changes Sep 2, 2024

View reviewed changes

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 18, 2024

fauxpark requested changes Oct 18, 2024

View reviewed changes

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 20, 2024

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 4, 2024

github-actions bot closed this Jan 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[keyboard]Graystudio BD60 Support #22210

[keyboard]Graystudio BD60 Support #22210

edwardslau commented Oct 5, 2023 •

edited

Loading

zvecr Oct 5, 2023

zvecr Feb 1, 2024

dunk2k Dec 31, 2023

fauxpark Jan 14, 2024

fauxpark Jan 17, 2024

fauxpark Oct 18, 2024

zvecr Jan 17, 2024

zvecr Feb 1, 2024

zvecr Feb 1, 2024

tzarc commented Aug 26, 2024

dunk2k Sep 2, 2024

github-actions bot commented Oct 18, 2024

fauxpark Oct 18, 2024

fauxpark Oct 18, 2024

fauxpark Oct 18, 2024

fauxpark Oct 18, 2024

fauxpark Oct 18, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Jan 4, 2025

	_______, RGB_TOG, RGB_MOD, RGB_HUI, RGB_HUD, RGB_SAI, RGB_SAD, RGB_VAI, RGB_VAD, _______, _______, _______, _______, _______,
	_______, UG_TOGG, UG_NEXT, UG_HUEU, UG_HUED, UG_SATU, UG_SATD, UG_VALU, UG_VALD, _______, _______, _______, _______, _______,

[keyboard]Graystudio BD60 Support #22210

[keyboard]Graystudio BD60 Support #22210

Conversation

edwardslau commented Oct 5, 2023 • edited Loading

Description

Types of Changes

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tzarc commented Aug 26, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 4, 2024

github-actions bot commented Jan 4, 2025

edwardslau commented Oct 5, 2023 •

edited

Loading