Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fullsize_extended_(ansi|iso) community_layouts in keyboards #22184

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Oct 2, 2023

Follow up from #21402

Description

  • add fullsize_extended* Community Layouts to applicable keyboards
    • added alias(es) for prior layout name(s)
  • where information available, add matrix_diagram.md

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dunk2k dunk2k marked this pull request as ready for review October 2, 2023 14:25
@dunk2k dunk2k changed the base branch from develop to master December 5, 2023 16:38
@dunk2k dunk2k force-pushed the comm_layout_fs_ex branch from d35cb65 to b0300a3 Compare December 5, 2023 16:38
@dunk2k dunk2k changed the base branch from master to develop December 12, 2023 12:54
@dunk2k dunk2k changed the base branch from develop to master March 14, 2024 23:04
@dunk2k dunk2k changed the base branch from master to develop March 19, 2024 16:27
@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Apr 2, 2024
@dunk2k dunk2k changed the title amend fullsize_extended_(ansi|iso) community_layouts in keyboards/ add fullsize_extended_(ansi|iso) community_layouts in keyboards Apr 12, 2024
Copy link

github-actions bot commented Jul 3, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 3, 2024
@dunk2k
Copy link
Contributor Author

dunk2k commented Jul 3, 2024

Please label as awaiting review

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jul 4, 2024
@tzarc
Copy link
Member

tzarc commented Aug 26, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 11, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 23, 2024
Copy link

github-actions bot commented Dec 7, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants