Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer eeconfig identifiers #22135

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Infer eeconfig identifiers #22135

merged 2 commits into from
Mar 14, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 25, 2023 •
edited
Loading

Description

Removes hard coded values, potentially allowing them to be ifdefed to reduced size in the future.

Slight tidy up to eeconfig init while changing the file.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Sep 25, 2023
sigprof
sigprof requested changes Sep 25, 2023
View reviewed changes
quantum/eeconfig.h Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 14, 2023
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Dec 15, 2023
@tzarc tzarc added in progress stale Issues or pull requests that have become inactive without resolution. and removed stale Issues or pull requests that have become inactive without resolution. labels Dec 16, 2023
@tzarc tzarc reopened this Dec 16, 2023
@zvecr zvecr force-pushed the eeconfig_offsetof branch from 191cb84 to 63b3ba1 Compare December 16, 2023 00:50
@github-actions github-actions bot removed the keymap label Dec 16, 2023
@tzarc tzarc merged commit 4bbfeca into develop Mar 14, 2024
4 checks passed
@tzarc tzarc deleted the eeconfig_offsetof branch March 14, 2024 10:45
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@zvecr @tzarc @mechlovin
Infer eeconfig identifiers (qmk#22135)
5650144 
Co-authored-by: Nick Brassel <[email protected]>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@zvecr @tzarc @mechlovin
Infer eeconfig identifiers (qmk#22135)
ad6de0f 
Co-authored-by: Nick Brassel <[email protected]>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
@zvecr @tzarc @mechlovin
Infer eeconfig identifiers (qmk#22135)
9eacf2f 
Co-authored-by: Nick Brassel <[email protected]>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@zvecr @tzarc @whoisjordangarcia
Infer eeconfig identifiers (qmk#22135)
e9c7cc1 
Co-authored-by: Nick Brassel <[email protected]>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @tzarc @nuess0r
Infer eeconfig identifiers (qmk#22135)
61a12a9 
Co-authored-by: Nick Brassel <[email protected]>
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@zvecr @tzarc @Ardakilic
Infer eeconfig identifiers (qmk#22135)
bc9b984 
Co-authored-by: Nick Brassel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@sigprof sigprof sigprof requested changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core in progress stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @sigprof @drashna @tzarc