Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reminder about format-json to PR Checklist #22055

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Add reminder about format-json to PR Checklist #22055

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5577d5
PR Checklist format-json reminder
lendunistus Sep 17, 2023
0612fcb
Applied suggested clarification
lendunistus Sep 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/pr_checklist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard
- Encoder Configuration
- Bootmagic Configuration
- LED Indicator Configuration
- run `qmk format-json` on this file before submitting your PR
lendunistus marked this conversation as resolved.
Show resolved Hide resolved
- `readme.md`
- must follow the [template](https://github.com/qmk/qmk_firmware/blob/master/data/templates/keyboard/readme.md)
- flash command is present, and has `:flash` at end
Expand Down