-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and use I2C address defines for ISSI LED drivers #22008
Conversation
These boards are yet to be done:
They have |
Strange that the I2C address seem identical to CKLED2001 / SLED173x LED driver there? Maybe those chip in some case can be compatible with IS31FL3733 code? |
Comparing the datasheets, there are a lot of similarities in the register layouts 🤔 The function page is significantly changed, but it looks like the 3733 driver only writes to registers which wouldn't exist on the CKLED2001 so it should be "safe". It does write to the configuration/"software shut down" register ( |
Turns out CKLED2001 is just SNLED27351, which is what the above listed boards use as well. So this PR is ready to go, and the rest of this mess will be cleaned up in a subsequent PR. |
Description
Less magic numbers.
Types of Changes
Issues Fixed or Closed by This PR
Checklist