Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fc660c/fc980c: clean up actuation point adjustment code #21964

Merged
merged 2 commits into from
Sep 14, 2023
Merged

fc660c/fc980c: clean up actuation point adjustment code #21964

merged 2 commits into from
Sep 14, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Sep 9, 2023

Description

Removed custom I2C implementation in favour of core i2c_master, and tidied up the AD5258 driver used for actuation point adjustment.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 9, 2023 08:57
zvecr
zvecr requested changes Sep 9, 2023
View reviewed changes
keyboards/fc660c/fc660c.h Show resolved Hide resolved
keyboards/fc980c/fc980c.h Show resolved Hide resolved
@fauxpark fauxpark requested a review from zvecr September 13, 2023 19:22
@fauxpark fauxpark merged commit f9ed1e3 into qmk:develop Sep 14, 2023
@fauxpark fauxpark deleted the fc660c-fc980c-i2c-cleanup branch September 14, 2023 03:57
@wlhlm wlhlm mentioned this pull request Oct 12, 2023
Closed
14 tasks
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@fauxpark @zvecr @mechlovin
fc660c/fc980c: clean up actuation point adjustment code (qmk#21964)
6b3f2e6 
Co-authored-by: Joel Challis <[email protected]>
@wlhlm wlhlm mentioned this pull request Nov 28, 2023
Merged
14 tasks
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@fauxpark @zvecr @christrotter
fc660c/fc980c: clean up actuation point adjustment code (qmk#21964)
db067d3 
Co-authored-by: Joel Challis <[email protected]>
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@fauxpark @zvecr @zgagnon
fc660c/fc980c: clean up actuation point adjustment code (qmk#21964)
9b43397 
Co-authored-by: Joel Challis <[email protected]>
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@fauxpark @zvecr
fc660c/fc980c: clean up actuation point adjustment code (qmk#21964)
645b9c4 
Co-authored-by: Joel Challis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @zvecr