Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keyboard name from LAYOUT_moonlander #21940

Closed
wants to merge 1 commit into from

Conversation

3geek14
Copy link
Contributor

@3geek14 3geek14 commented Sep 7, 2023

This removes a build warning for moonlander:default.

Description

Rename LAYOUT_moonlander to LAYOUT in keyboards/moonlander/info.json. A small handful of keymaps exist in the repo, and two people referenced LAYOUT_moonlander in their user/ directories, so I updated uses in all of those files.

I tested building the default layout locally, and I'm expecting the CI to test everything else that's impacted by these files. I think this counts as a breaking change, which is why I'm targeting the develop branch.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

This removes a build warning for moonlander:default.

Signed-off-by: 3geek14 <[email protected]>
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 7, 2023
@fauxpark
Copy link
Member

fauxpark commented Sep 7, 2023

Already done in #21898

@fauxpark fauxpark closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants