Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aw20216: driver naming cleanups #21891

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Sep 3, 2023

Description

Renamed driver to AW20216S per below comment, and added AW20216S_ prefix to all defines.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@sigprof
Copy link
Contributor

sigprof commented Sep 3, 2023

BTW, this driver is actually for the AW20216S chip (full part number is AW20216SQNR): https://www.awinic.com/en/productDetail/AW20216SQNR. The current driver name is confusing, because the AW20216 (AW20216QNR) chip also exists: https://www.awinic.com/en/productDetail/AW20216QNR, but that chip uses I2C, not SPI.

Looks like the register layout for AW20216 and AW20216S is actually the same, and the only differences are related to the I2C or SPI access (the SPI variant uses a 2-byte prefix before data that specifies both the page and register address; the I2C variant uses a separate register for switching pages, similar to what various ISSI chips do). But with the current QMK infrastructure those chips would require separate drivers anyway.

@tzarc tzarc merged commit a0aebe5 into qmk:develop Sep 13, 2023
@fauxpark fauxpark deleted the aw20216-naming-cleanups branch September 13, 2023 12:52
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants