Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotary numpad #21744

Merged
merged 12 commits into from
Sep 25, 2023
Merged

Rotary numpad #21744

merged 12 commits into from
Sep 25, 2023

Conversation

RABijl
Copy link
Contributor

@RABijl RABijl commented Aug 13, 2023

Description

Contributing my personal numpad project to the repo

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

RABijl added 3 commits August 9, 2023 19:36
@RABijl
rotary_pad: add default numpad layout
9284c63 
an initial commit which setups up the
initial configurations such as the mcu
and pinlayout.
@RABijl
rotary_pad: add initial rotary functions
5ebd0d2 
sets up the three rotary encoders and
assigns some functions to them.
@RABijl
rotary_pad: add rotary button funcs and update readme
102847f
dunk2k
dunk2k suggested changes Aug 13, 2023
View reviewed changes
keyboards/rotary_numpad/config.h Outdated Show resolved Hide resolved
keyboards/rotary_numpad/readme.md Outdated Show resolved Hide resolved
keyboards/rotary_numpad/info.json Outdated Show resolved Hide resolved
keyboards/rotary_numpad/info.json Outdated Show resolved Hide resolved
@RABijl
rotary_pad: apply pr changes
22f77b7 
* removed config.h
* changed pic url
* changed proc + bl to dev board
* renamed LAYOUT_numpad_6x4 to LAYOUT_dense_6x4
@RABijl RABijl force-pushed the rabijl-pad-project branch from 05c0d4f to 22f77b7 Compare August 13, 2023 11:39
dunk2k
dunk2k suggested changes Aug 13, 2023
View reviewed changes
keyboards/rotary_numpad/info.json Outdated Show resolved Hide resolved
dunk2k
dunk2k suggested changes Aug 13, 2023
View reviewed changes
keyboards/rotary_numpad/info.json Outdated Show resolved Hide resolved
keyboards/rotary_numpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@dunk2k
Copy link
Contributor

dunk2k commented Aug 13, 2023

@RABijl
Could I suggest for your consideration regarding keymaps/default/keymap.c using encoder map functionality instead of encoder functions.

@RABijl
rotary_pad: fix layout and enable encoder mapping
9030281 
* also updated readme with new diagram
@RABijl
Copy link
Contributor Author

RABijl commented Aug 14, 2023

Thanks for all the feedback, I've applied the changes to layout and made use of encoder mapping.

dunk2k
dunk2k suggested changes Aug 14, 2023
View reviewed changes
keyboards/rotary_numpad/readme.md Outdated Show resolved Hide resolved
dunk2k
dunk2k suggested changes Aug 14, 2023
View reviewed changes
keyboards/rotary_numpad/readme.md Outdated Show resolved Hide resolved
@RABijl RABijl force-pushed the rabijl-pad-project branch from 4aecc6b to d49b579 Compare August 14, 2023 14:17
@RABijl
Copy link
Contributor Author

RABijl commented Aug 14, 2023

I've applied the suggested changes

dunk2k
dunk2k suggested changes Aug 14, 2023
View reviewed changes
keyboards/rotary_numpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/rotary_numpad/readme.md Outdated Show resolved Hide resolved
keyboards/rotary_numpad/readme.md Outdated Show resolved Hide resolved
keyboards/rotary_numpad/readme.md Outdated Show resolved Hide resolved
@RABijl RABijl marked this pull request as draft August 15, 2023 06:01
@RABijl RABijl changed the title Rotary numpad Draft: Rotary numpad Aug 15, 2023
@RABijl
Copy link
Contributor Author

RABijl commented Aug 15, 2023

I've changed this pr to a draft in order to not diverge attention while I address the issues and go over the guidelines again.

RABijl added 2 commits August 15, 2023 22:45
@RABijl
rotary_pad: move to handwired and apply conventions
f2a8360 
* keyboard is now under keyboards/handwired/rabijl/rotary_numpad
* encoder mapping is now enabled per keymap
* add bootmagic reboot instruction
* update readme for new location
* update keymatrix in readme
@RABijl
rotary_pad: increase encoder resolution
f785f4f 
more smooth usage and removes chatter
@RABijl RABijl force-pushed the rabijl-pad-project branch from 4575f21 to f785f4f Compare August 15, 2023 19:47
@RABijl
Copy link
Contributor Author

RABijl commented Aug 15, 2023

I've moved the files to the handwired dir and applied suggestions.
I saw that make files aren't allowed anymore in keymap dirs (link), so i've resorted to using a config.h .

@RABijl RABijl changed the title Draft: Rotary numpad Rotary numpad Aug 16, 2023
@RABijl RABijl marked this pull request as ready for review August 16, 2023 06:00
@RABijl @drashna
tab to space info.json
1cca5a4 
Co-authored-by: Drashna Jaelre <[email protected]>
@RABijl RABijl requested a review from zvecr August 17, 2023 14:02
@tzarc tzarc merged commit 4e7e824 into qmk:develop Sep 25, 2023
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@RABijl @dunk2k
@drashna @mechlovin
Rotary numpad (qmk#21744)
87acdfb 
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@RABijl @dunk2k
@drashna @christrotter
Rotary numpad (qmk#21744)
ce7e4f7 
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@RABijl @dunk2k
@drashna @zgagnon
Rotary numpad (qmk#21744)
21d84b6 
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@RABijl @dunk2k @drashna
Rotary numpad (qmk#21744)
163f8b4 
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@waffle87 waffle87 waffle87 left review comments

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RABijl @dunk2k @drashna @tzarc @zvecr @waffle87