Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tofujr v2 keyboard #21740

Merged
merged 3 commits into from
Sep 26, 2023
Merged

add tofujr v2 keyboard #21740

merged 3 commits into from
Sep 26, 2023

Conversation

moyi4681
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dunk2k
Copy link
Contributor

dunk2k commented Aug 12, 2023

Missing a readme.md file.
Template is available in /data/templates/keyboard

@drashna drashna requested a review from a team August 12, 2023 18:27
fauxpark
fauxpark requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should go to develop, as it modifies existing keyboard files.

@drashna drashna changed the base branch from master to develop September 3, 2023 03:46
@moyi4681 moyi4681 requested a review from fauxpark September 19, 2023 08:24
fauxpark
fauxpark requested changes Sep 19, 2023
View reviewed changes
keyboards/dztech/tofu/jr/v2/info.json Outdated Show resolved Hide resolved
@moyi4681 moyi4681 requested a review from fauxpark September 25, 2023 09:06
@drashna drashna merged commit 1acecc3 into qmk:develop Sep 26, 2023
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@moyi4681 @fauxpark @mechlovin
add tofujr v2 keyboard (qmk#21740)
c3bbdce 
Co-authored-by: Ryan <[email protected]>
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@moyi4681 @fauxpark @christrotter
add tofujr v2 keyboard (qmk#21740)
f5f2577 
Co-authored-by: Ryan <[email protected]>
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@moyi4681 @fauxpark @zgagnon
add tofujr v2 keyboard (qmk#21740)
8f25f1c 
Co-authored-by: Ryan <[email protected]>
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@moyi4681 @fauxpark
add tofujr v2 keyboard (qmk#21740)
6812bef 
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moyi4681 @dunk2k @drashna @fauxpark