Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keyboard] tominabox1/le_chiffre oled rework #21611

Merged
merged 8 commits into from
Sep 15, 2023
Merged

[keyboard] tominabox1/le_chiffre oled rework #21611

merged 8 commits into from
Sep 15, 2023

Conversation

lesshonor
Copy link
Contributor

@lesshonor lesshonor commented Jul 25, 2023 •
edited
Loading

Description

Provides OLED functionality at the keyboard level, and refactors the individual keymaps to better leverage now-shared functions. A follow-up to #21567.

  • Layer status display handles non-zero default layers and degrades gracefully in the absence of named layers.
  • Improves and modernizes keylogger. (I excluded this from the keyboard-level implementation because it wasn't part of the package before, and there's no easy way to opt out from Configurator.)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 25, 2023
@lesshonor lesshonor force-pushed the develop/le_chiffre_oled branch from 24eb58b to 614a8de Compare August 10, 2023 15:22
@lesshonor lesshonor force-pushed the develop/le_chiffre_oled branch from 52f4b21 to dc5717c Compare August 23, 2023 03:19
@lesshonor
refactor: mv stock OLED functionality to kb level
882c44b
@lesshonor
fix: guard OLED-only variables
fc13e9c
@lesshonor
perf: use extern variables for constants
396ec89
@lesshonor
feat[oled]: improve layer display & customization
f910b3d 
Using oled_write_ln indiscriminately resulted in an unintended blank
line if the layer name was long enough to fill the entire row.

Relocating the section breaks allows keymaps to omit or override the
characters used while still leveraging keyboard-level functions.
@lesshonor
perf: don't use blank string, cap update interval
876c1c3
@lesshonor
refactor: move OLED_UPDATE_INTERVAL to post_config
c4aab9c
@lesshonor lesshonor force-pushed the develop/le_chiffre_oled branch from dc5717c to c4aab9c Compare August 27, 2023 03:01
@drashna drashna requested a review from a team August 30, 2023 03:39
@lesshonor @drashna
style: correct formatting
fc6e183 
Co-authored-by: Drashna Jaelre <[email protected]>
@drashna drashna requested a review from a team September 3, 2023 03:59
@lesshonor
perf: use memcpy instead of strncpy
a0ed557 
More portable and results in smaller firmware.
@lesshonor
Copy link
Contributor Author

I try not to actively pester people re: PRs, but I made a last-second change that you may have opinions about (using memcpy instead of strcpy).

I was unaware that there is no implementation of strncpy in arm-gcc until yesterday. An STM32 revision of this PCB already exists out-of-tree, and I'm trying not to put obstacles in the way of its potential submission. (Unfortunately, strlcpy increases the firmware size by ~100B over memcpy, which is pretty rough for AVR.)

@drashna drashna merged commit 134b60b into qmk:develop Sep 15, 2023
@lesshonor lesshonor deleted the develop/le_chiffre_oled branch September 15, 2023 23:54
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@lesshonor @drashna @mechlovin
[keyboard] tominabox1/le_chiffre oled rework (qmk#21611)
f66f102 
Co-authored-by: Drashna Jaelre <[email protected]>
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@lesshonor @drashna @christrotter
[keyboard] tominabox1/le_chiffre oled rework (qmk#21611)
79dc1d7 
Co-authored-by: Drashna Jaelre <[email protected]>
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@lesshonor @drashna @zgagnon
[keyboard] tominabox1/le_chiffre oled rework (qmk#21611)
0f43aa5 
Co-authored-by: Drashna Jaelre <[email protected]>
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@lesshonor @drashna
[keyboard] tominabox1/le_chiffre oled rework (qmk#21611)
0d39fd9 
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lesshonor @drashna @fauxpark @zvecr