Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dactyl_manuform_rp2040 #21538

Closed
wants to merge 1 commit into from
Closed

Add dactyl_manuform_rp2040 #21538

wants to merge 1 commit into from

Conversation

GustawXYZ
Copy link
Contributor

Adds new keyboard under handwired/dactyl_manuform_rp2040

It is a mashup of alcor_datyl nad dactyl_manuform(5x6)

Description

Started by cloning alcor_dactyl. Changed GPIOs to be Raspberry Pi Pico friendly.
Changed the layout to use dactyl_manuform 5x6. Added my default keymap.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [NA?] I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@GustawXYZ GustawXYZ changed the base branch from master to develop July 15, 2023 17:51
@dunk2k
Copy link
Contributor

dunk2k commented Jul 16, 2023

@GustawXYZ

Would you be able to change dactyl_manuform_rp2040 to dactyl_manuform_pi_pico as not to confuse terminology with QMK's rp2040 based converters and rp2040 development boards?

@GustawXYZ
Copy link
Contributor Author

Thanks a lot for the review! I will fix it and update the PR

@GustawXYZ
Add dactyl_manuform_pi_pico
1044190 
Adds new keyboard under handwired/dactyl_manuform_pi_pico

It is a mashup of alcor_datyl nad dactyl_manuform(5x6)
drashna
drashna requested changes Sep 15, 2023
View reviewed changes
keyboards/handwired/dactyl_manuform_pi_pico/config.h
#define SERIAL_USART_TX_PIN GP9
#define SERIAL_USART_RX_PIN GP8
#define RGB_MATRIX_LED_COUNT 2
#define EE_HANDS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a heads up, ee hands isn't great on ARM based boards, like this. split pin handedness is better, if you have the spare gpio. Also, split matrix handedness can also work (just needs matrix masking to be enabled so it doesn't keep it on)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointer. I don't think I've noticed any issues using the keyboard for last month or two. Although pi pico has plenty GPIO. What would be the symtomps of this? Bacause I'm not sure if it's worth resoldering

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly, user experience. If it's working fine, that that's okay.

keyboards/handwired/dactyl_manuform_pi_pico/info.json
"rows": ["GP21", "GP20", "GP19", "GP18", "GP17", "GP16"]
},
"rgb_matrix": {
"driver": "WS2812",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"driver": "WS2812",
"driver": "ws2812",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I was going to look into that in some spare time

keyboards/handwired/dactyl_manuform_pi_pico/readme.md

Make example for this keyboard (after setting up your build environment):

make dactyl_manuform_pi_pico:default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
make dactyl_manuform_pi_pico:default
make handwired/dactyl_manuform_pi_pico:default

keyboards/handwired/dactyl_manuform_pi_pico/readme.md

Flashing example for this keyboard:

make dactyl_manuform_pi_pico:default:flash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
make dactyl_manuform_pi_pico:default:flash
make handwired/dactyl_manuform_pi_pico:default:flash

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 14, 2023
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Dec 15, 2023
@GustawXYZ GustawXYZ mentioned this pull request Jun 9, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna requested changes

@dunk2k dunk2k dunk2k requested changes

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GustawXYZ @dunk2k @drashna