Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aleblazer/zodiark:via: Disable two RGB effects #21495

Merged
merged 1 commit into from
Jul 10, 2023
Merged

aleblazer/zodiark:via: Disable two RGB effects #21495

merged 1 commit into from
Jul 10, 2023

Conversation

filterpaper
Copy link
Contributor

Description

Remove two effects to bring firmware size under the limit

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@filterpaper
aleblazer/zodiark:via: Disable some RGB effects
67c8d19 
Remove two effects to bring firmware size under the limit
@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Jul 10, 2023
@waffle87 waffle87 requested a review from a team July 10, 2023 02:36
@fauxpark fauxpark merged commit 1fd1012 into qmk:develop Jul 10, 2023
@filterpaper filterpaper deleted the fix-zodiark-size branch July 10, 2023 03:38
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@filterpaper @jesperhellberg
aleblazer/zodiark:via: Disable two RGB effects (qmk#21495)
db2a4fb
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@filterpaper @thismarvin
aleblazer/zodiark:via: Disable two RGB effects (qmk#21495)
833cf10
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@filterpaper @akeep
aleblazer/zodiark:via: Disable two RGB effects (qmk#21495)
5d99b4a
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@filterpaper @csolje
aleblazer/zodiark:via: Disable two RGB effects (qmk#21495)
0570749
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@filterpaper @autoferrit
aleblazer/zodiark:via: Disable two RGB effects (qmk#21495)
3ca4d4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @fauxpark @waffle87