Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dp3000 macropad rev2 #21478

Closed
wants to merge 47 commits into from
Closed

add dp3000 macropad rev2 #21478

wants to merge 47 commits into from

Conversation

depermana12
Copy link
Contributor

@depermana12 depermana12 commented Jul 8, 2023 •
edited
Loading

Description

  • update oled logo
  • add rev2 support rgblight underglow, and restructure the folder

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Jul 8, 2023
View reviewed changes
keyboards/dp3000/dp3000.c Outdated Show resolved Hide resolved
keyboards/dp3000/rev1/info.json Show resolved Hide resolved
keyboards/dp3000/rev2/info.json Outdated Show resolved Hide resolved
@depermana12 depermana12 requested a review from drashna July 8, 2023 09:31
@drashna drashna requested a review from a team July 8, 2023 20:34
fauxpark
fauxpark requested changes Jul 9, 2023
View reviewed changes
keyboards/dp3000/rev2/config.h Outdated Show resolved Hide resolved
keyboards/dp3000/dp3000.h Show resolved Hide resolved
keyboards/dp3000/dp3000.c Outdated Show resolved Hide resolved
@depermana12 depermana12 requested a review from fauxpark July 9, 2023 03:57
@drashna drashna requested a review from a team July 11, 2023 06:55
@depermana12
Copy link
Contributor Author

Is there anything else I need to do to get PR accepted?

@depermana12
Copy link
Contributor Author

bumping, it's been a while. can i get a code review

fauxpark
fauxpark requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard updates need to go through develop.

@depermana12 depermana12 changed the base branch from master to develop August 26, 2023 07:11
@depermana12
Copy link
Contributor Author

Member

I've followed your suggestion, changed from master to develop

@depermana12
Copy link
Contributor Author

hi @fauxpark Please kindly help check my PR again, is there anything else need to change to get this PR merge? because these macropad have ready to ship and need to support via auto-detect.

@noroadsleft
Abko AK84BT Layout Touch-Up (qmk#21876)
ab9e74a 
* [refactor] rename LAYOUT_75_ansi to LAYOUT

* [enhancement] touch-up layout
fauxpark
fauxpark requested changes Sep 1, 2023
View reviewed changes
keyboards/dp3000/rev1/info.json Outdated Show resolved Hide resolved
noroadsleft and others added 17 commits September 1, 2023 01:36
@noroadsleft
AH Haven65 Community Layout support (qmk#21880)
4b1aa16 
* [refactor] rename LAYOUT to LAYOUT_65_ansi_blocker

* [enhancement] enable Community Layout support
@jaygreco
nullbitsco/snap: fix broken keymaps (qmk#21877)
81ea4f9
@frankebel
chore: ignore virtual environment directory (qmk#20905)
633d92a
@ziptyze @dunk2k
Add 1upkeyboards Super16v3 (qmk#21665)
b03b49f 
Co-authored-by: Duncan Sutherland <[email protected]>
@temp4gh @dunk2k
@waffle87 @fauxpark
[keyboard] add redragon/k667 (qmk#21417)
04ce349 
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: syc <[email protected]>
@ToastyStoemp @zvecr @drashna
Add M6-C Keyboard Firmware (qmk#21852)
47e72a9 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Wolf <[email protected]>
@NCKiser @drashna @fauxpark
Added kiserdesigns keyboard folder and Madeline keyboard (qmk#21857)
8ad43a9 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
@zvecr
redragon/k667: Remove 2 layer VIA restriction (qmk#21889)
e26442f
@noroadsleft
AH Haven80 Community Layout support (qmk#21885)
dd17b6b 
* [enhancement] correct layout data

* [refactor] rename LAYOUT to LAYOUT_tkl_f13_ansi_tsangan

* [enhancement] enable Community Layout support

* Haven80 Solder: add LAYOUT_tkl_f13_ansi_tsangan_split_bs_rshift

[enhancement]

* Haven80 Solder: add LAYOUT_tkl_f13_iso_tsangan_split_bs_rshift

[enhancement]

* Haven80 Solder: add LAYOUT_tkl_f13_iso_tsangan

[enhancement]

* Haven80 Solder: extend Community Layout support

[enhancement]
@noroadsleft
ANAVI Macro Pad 12: rename LAYOUT to LAYOUT_ortho_4x3 (qmk#21886)
9eaa8a2 
[refactor]
@noroadsleft
Chosfox CF81: correct layout data (qmk#21902)
fd095bb
@zvecr
Auto-label data-driven efforts (qmk#21900)
b2ded61
@noroadsleft
CannonKeys Bastion75 Layout Additions (qmk#21899)
2f51704 
* [docs] add layout/matrix diagram

* [refactor] rename LAYOUT to LAYOUT_all

* [enhancement] add LAYOUT_ansi_blocker_split_bs

* [enhancement] add LAYOUT_ansi_blocker

* [enhancement] add LAYOUT_ansi_blocker_tsangan_split_bs

* [enhancement] add LAYOUT_ansi_blocker_tsangan

* [enhancement] add LAYOUT_iso_blocker_split_bs

* [enhancement] add LAYOUT_iso_blocker

* [enhancement] add LAYOUT_iso_blocker_tsangan_split_bs

* [enhancement] add LAYOUT_iso_blocker_tsangan
@noroadsleft
CannonKeys Bastion60 Layout Additions (qmk#21887)
2f243e2 
* [bugfix] correct LAYOUT_60_iso_tsangan key order

* [docs] add layout/matrix diagram

* [enhancement] add LAYOUT_60_tsangan_hhkb

* [enhancement] add LAYOUT_60_ansi_tsangan

* [enhancement] add LAYOUT_60_iso

* [enhancement] add LAYOUT_60_iso_split_bs_rshift

* [enhancement] add LAYOUT_60_iso_tsangan_split_bs_rshift

* [enhancement] add LAYOUT_60_hhkb

* [enhancement] extend Community Layout support
@noroadsleft
CannonKeys Bastion65 Layout Additions (qmk#21888)
809865e 
* [docs] add layout/matrix diagram

* [refactor] rename LAYOUT to LAYOUT_all

* [enhancement] add LAYOUT_65_ansi_blocker_split_bs

* [enhancement] add LAYOUT_65_ansi_blocker

* [enhancement] add LAYOUT_65_ansi_blocker_tsangan_split_bs

* [enhancement] add LAYOUT_65_ansi_blocker_tsangan

* [enhancement] add LAYOUT_65_iso_blocker_split_bs

* [enhancement] add LAYOUT_65_iso_blocker

* [enhancement] add LAYOUT_65_iso_blocker_tsangan_split_bs

* [enhancement] add LAYOUT_65_iso_blocker_tsangan

* [enhancement] enable Community Layout support
@noroadsleft
CannonKeys BastionTKL Layout Additions (qmk#21901)
6aa3814 
* [docs] add layout/matrix diagram

* [enhancement] add LAYOUT_tkl_ansi_split_bs_rshift

* [enhancement] add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

* [enhancement] add LAYOUT_tkl_ansi_tsangan

* [enhancement] add LAYOUT_tkl_f13_ansi_tsangan

* [enhancement] add LAYOUT_tkl_f13_ansi_split_bs_rshift

* [enhancement] add LAYOUT_tkl_f13_ansi

* [enhancement] correct LAYOUT_tkl_iso key order

* [enhancement] add LAYOUT_tkl_iso_split_bs_rshift

* [enhancement] add LAYOUT_tkl_iso_tsangan_split_bs_rshift

* [enhancement] add LAYOUT_tkl_iso_tsangan

* [enhancement] add LAYOUT_tkl_f13_iso_split_bs_rshift

* [enhancement] add LAYOUT_tkl_f13_iso

* [enhancement] add LAYOUT_tkl_f13_iso_tsangan_split_bs_rshift

* [enhancement] add LAYOUT_tkl_f13_iso_tsangan

* [enhancement] extend Community Layout support
@depermana12
Merge branch 'qmk:master' into revision-2
8779539
@github-actions github-actions bot added core keymap via Adds via keymap and/or updates keyboard for via support CI labels Sep 5, 2023
@depermana12 depermana12 closed this Sep 6, 2023
@depermana12 depermana12 mentioned this pull request Sep 20, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
CI core keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.