Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jones/v1: fix layout offset and disable audio on via keymap #21468

Merged
merged 1 commit into from
Jul 7, 2023
Merged

jones/v1: fix layout offset and disable audio on via keymap #21468

merged 1 commit into from
Jul 7, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jul 7, 2023

Description

Since it seems to be compiling oversize now and failing CI.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added bug keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 7, 2023
@fauxpark fauxpark requested a review from a team July 7, 2023 09:43
@tzarc tzarc merged commit 4928f4c into qmk:develop Jul 7, 2023
@fauxpark fauxpark deleted the jones-via-keymap-fix branch July 7, 2023 11:19
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@fauxpark @jesperhellberg
jones/v1: fix layout offset and disable audio on via keymap (qmk#21468)
1b96992
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@fauxpark @thismarvin
jones/v1: fix layout offset and disable audio on via keymap (qmk#21468)
f3ef436
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@fauxpark @akeep
jones/v1: fix layout offset and disable audio on via keymap (qmk#21468)
4bd3fcc
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@fauxpark @csolje
jones/v1: fix layout offset and disable audio on via keymap (qmk#21468)
3c02be4
@jpskenn jpskenn mentioned this pull request Nov 2, 2023
Open
39 tasks
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@fauxpark @autoferrit
jones/v1: fix layout offset and disable audio on via keymap (qmk#21468)
d870d9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @tzarc