Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for auto mouse movement threshold #21398

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Add option for auto mouse movement threshold #21398

merged 5 commits into from
Jan 9, 2024

Conversation

MarcelRobitaille
Copy link
Contributor

Add a threshold for a minimum amount of mouse movement before activating the auto mouse layer. Right now, any movement at all triggers the mouse layer. I have a BastardKB Charybdis and I've noticed that I often nudge the trackball when pressing other keys.

Description

Adds a new configuration option for the auto mouse feature AUTO_MOUSE_THRESHOLD. If the mouse is bumped by a distance below this threshold, the auto mouse layer is not activated. The mouse distance is accumulated over multiple events in case a single mouse event does not move the mouse over this threshold (it would have to be a relatively quick movement).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (It's just a draft PR. I will update the docs if we move forward)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jun 27, 2023
@zvecr zvecr changed the base branch from master to develop June 28, 2023 00:20
@drashna drashna requested a review from a team July 3, 2023 09:58
@drashna drashna self-assigned this Oct 19, 2023
@drashna drashna requested review from drashna and a team October 19, 2023 21:32
@MarcelRobitaille MarcelRobitaille marked this pull request as ready for review October 22, 2023 10:13
@drashna drashna removed the needs doc label Oct 22, 2023
@drashna drashna requested a review from a team October 22, 2023 19:32
@drashna drashna requested a review from daskygit November 29, 2023 07:48
@tzarc tzarc merged commit ce05dc6 into qmk:develop Jan 9, 2024
1 of 2 checks passed
@drashna drashna mentioned this pull request Feb 24, 2024
Closed
14 tasks
at6ue added a commit to at6ue/qmk_firmware that referenced this pull request Apr 11, 2024
@at6ue
Apply patch from "Add option for auto mouse movement threshold qmk#21398
a349ae1 
"

https://github.com/qmk/qmk_firmware/pull/21398/files
@okuRaku okuRaku mentioned this pull request Apr 22, 2024
Open
hiroshinoji pushed a commit to hiroshinoji/qmk_firmware that referenced this pull request May 30, 2024
@MarcelRobitaille @hiroshinoji
Add option for auto mouse movement threshold (qmk#21398)
3cfed14 
Fixes qmk#21396
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@MarcelRobitaille @nuess0r
Add option for auto mouse movement threshold (qmk#21398)
d8307f2 
Fixes qmk#21396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@daskygit daskygit Awaiting requested review from daskygit

Assignees

@drashna drashna

Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Auto Mouse Threshold
3 participants
@MarcelRobitaille @drashna @tzarc