Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup head reference for CI keyboard count verification #21395

Closed
wants to merge 2 commits into from

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jun 27, 2023

Description

Fixes #21246.

github.ref points at refs/pull/<pr_number>/merge -- see https://docs.github.com/en/actions/learn-github-actions/contexts#github-context

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested review from sigprof and a team June 27, 2023 11:42
Copy link
Contributor

@sigprof sigprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested modification at least does not fail completely, although the check is not ideal (the PR may remove 1 keyboard and add 2 new keyboards at the same time, and the keyboard count check would succeed).

BTW, some other things probably can be checked here automatically:

  • If any keyboards are removed, the PR must target develop. (This would catch even cases when the old keyboard name becomes an alias, because qmk list-keyboards resolves both DEFAULT_FOLDER and keyboard_aliases.hjson aliases, so any old names that became aliases would be detected as removed even if rules.mk with DEFAULT_FOLDER remains at the old location.)
  • If any keyboards are removed, the old names should remain valid as aliases (in this case the removed names might not appear in the output of qmk list-keyboards --no-resolve-defaults if the aliases are only in keyboard_aliases.hjson; not sure what would be the best check for this, but it should be possible).

.github/workflows/lint.yml Outdated Show resolved Hide resolved
@tzarc tzarc closed this Oct 24, 2023
@tzarc tzarc deleted the tzarc-patch-1 branch October 24, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants