Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move miscellaneous defines to data driven #21382

Merged
merged 2 commits into from
Jul 2, 2023
Merged

Conversation

fauxpark
Copy link
Member

Description

Moved a bunch of defines with too few instances to warrant separate PRs:
LEADER_TIMEOUT -> leader_key.timeout
LEADER_PER_KEY_TIMING -> leader_key.timing
RGB_MATRIX_TIMEOUT -> rgb_matrix.timeout
MATRIX_IO_DELAY -> matrix_pins.io_delay

Moved defines that were missed (indicators, encoders, matrix, ws2812, polling interval)

Removed some pointless code:
Commented DIODE_DIRECTION in custom matrix boards
LED_PIN_ON_STATE 1 in .c

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 25, 2023 20:57
@fauxpark
Copy link
Member Author

Only two SHA mismatches are ash1800 and ash_xiix, as expected.

@zvecr zvecr merged commit 023035f into qmk:develop Jul 2, 2023
@fauxpark fauxpark deleted the misc-data-driven branch July 2, 2023 22:37
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
jashort pushed a commit to jashort/qmk_firmware that referenced this pull request Nov 20, 2023
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants