Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pixel fractal: Set minimum middle column value #21365

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Pixel fractal: Set minimum middle column value #21365

merged 1 commit into from
Jul 7, 2023

Conversation

filterpaper
Copy link
Contributor

Description

Set a minimum middle column value of 1 to avoid integer rounding to zero on division when MATRIX_COLS is less than 2

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Reported by @drashna on Discord when effect was tested with MATRIX_COLS = 1

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@filterpaper
Set minimum middle column value
a16b693 
Set a minimum middle column value of `1` to avoid integer
rounding to zero on division when `MATRIX_COLS` is less than 2
@github-actions github-actions bot added the core label Jun 24, 2023
@drashna drashna requested a review from a team June 24, 2023 14:56
@tzarc tzarc merged commit 0035ed6 into qmk:develop Jul 7, 2023
@filterpaper filterpaper deleted the fractal-col-fix branch July 7, 2023 19:58
@tzarc tzarc added the bug label Aug 27, 2023
@tzarc tzarc changed the title Set minimum middle column value Pixel fractal: Set minimum middle column value Aug 27, 2023
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@filterpaper @jesperhellberg
Set minimum middle column value (qmk#21365)
563df53
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@filterpaper @thismarvin
Set minimum middle column value (qmk#21365)
4dd890a
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@filterpaper @akeep
Set minimum middle column value (qmk#21365)
7a24721
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@filterpaper @csolje
Set minimum middle column value (qmk#21365)
237a161
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@filterpaper @autoferrit
Set minimum middle column value (qmk#21365)
adfd0f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @drashna @tzarc