Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RGB_MATRIX_HUE/SAT/VAL/SPD_STEP to data driven #21354

Merged
merged 2 commits into from
Jun 24, 2023
Merged

Move RGB_MATRIX_HUE/SAT/VAL/SPD_STEP to data driven #21354

merged 2 commits into from
Jun 24, 2023

Conversation

fauxpark
Copy link
Member

Description

RGB_MATRIX_(HUE|SAT|VAL|SPD)_STEP -> rgb_matrix.(hue|sat|val|speed)_steps

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 23, 2023 16:42
@fauxpark
Copy link
Member Author

Build failures unrelated.

@fauxpark
Copy link
Member Author

SHAs all match.

@tzarc tzarc merged commit 6545eb6 into qmk:develop Jun 24, 2023
@fauxpark fauxpark deleted the rgb-matrix-hsv-step-data-driven branch June 24, 2023 07:14
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@fauxpark @jesperhellberg
Move RGB_MATRIX_HUE/SAT/VAL/SPD_STEP to data driven (qmk#21354)
d84d99b
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@fauxpark @thismarvin
Move RGB_MATRIX_HUE/SAT/VAL/SPD_STEP to data driven (qmk#21354)
8a96fc3
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@fauxpark @akeep
Move RGB_MATRIX_HUE/SAT/VAL/SPD_STEP to data driven (qmk#21354)
7a143f0
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@fauxpark @csolje
Move RGB_MATRIX_HUE/SAT/VAL/SPD_STEP to data driven (qmk#21354)
f970a23
jashort pushed a commit to jashort/qmk_firmware that referenced this pull request Nov 20, 2023
@fauxpark @jashort
Move RGB_MATRIX_HUE/SAT/VAL/SPD_STEP to data driven (qmk#21354)
acb8fca
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@fauxpark @autoferrit
Move RGB_MATRIX_HUE/SAT/VAL/SPD_STEP to data driven (qmk#21354)
3433859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @tzarc