Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RGBLED_NUM to data driven #21278

Merged
merged 31 commits into from
Jun 18, 2023
Merged

Move RGBLED_NUM to data driven #21278

merged 31 commits into from
Jun 18, 2023

Conversation

fauxpark
Copy link
Member

Description

RGBLED_NUM -> rgblight.led_count

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark added 28 commits June 18, 2023 05:33
@fauxpark
RGBLED_NUM -> rgblight.led_count, 0-9
70691f1
@fauxpark
RGBLED_NUM -> rgblight.led_count, A
5670bd4
@fauxpark
RGBLED_NUM -> rgblight.led_count, B
3a94b9d
@fauxpark
RGBLED_NUM -> rgblight.led_count, C
15d2ba3
@fauxpark
RGBLED_NUM -> rgblight.led_count, D
d8f60cb
@fauxpark
RGBLED_NUM -> rgblight.led_count, E
94655de
@fauxpark
RGBLED_NUM -> rgblight.led_count, F
39a5f5b
@fauxpark
RGBLED_NUM -> rgblight.led_count, G
0c88289
@fauxpark
RGBLED_NUM -> rgblight.led_count, H
2103df8
@fauxpark
RGBLED_NUM -> rgblight.led_count, handwired
089a90c
@fauxpark
RGBLED_NUM -> rgblight.led_count, I
ac26a6e
@fauxpark
RGBLED_NUM -> rgblight.led_count, J
97ddd08
@fauxpark
RGBLED_NUM -> rgblight.led_count, K
3ed9279
@fauxpark
RGBLED_NUM -> rgblight.led_count, L
fc7e5b5
@fauxpark
RGBLED_NUM -> rgblight.led_count, M
74afc8b
@fauxpark
RGBLED_NUM -> rgblight.led_count, N
a5b65a0
@fauxpark
RGBLED_NUM -> rgblight.led_count, O
342b6a8
@fauxpark
RGBLED_NUM -> rgblight.led_count, P
868db92
@fauxpark
RGBLED_NUM -> rgblight.led_count, Q
b9469b6
@fauxpark
RGBLED_NUM -> rgblight.led_count, R
948a098
@fauxpark
RGBLED_NUM -> rgblight.led_count, S
4755e32
@fauxpark
RGBLED_NUM -> rgblight.led_count, T
df67e1e
@fauxpark
RGBLED_NUM -> rgblight.led_count, U
2c62054
@fauxpark
RGBLED_NUM -> rgblight.led_count, V
4f93d23
@fauxpark
RGBLED_NUM -> rgblight.led_count, W
6de3854
@fauxpark
RGBLED_NUM -> rgblight.led_count, X
837d76d
@fauxpark
RGBLED_NUM -> rgblight.led_count, Y
74dadb2
@fauxpark
RGBLED_NUM -> rgblight.led_count, Z
65a031f
@fauxpark fauxpark requested a review from a team June 17, 2023 19:45
@fauxpark
Copy link
Member Author

SHA mismatches, not sure why:

c42f453e0b2bc2ded37739d375405dd374390e19  jian_rev1_default.hex  |     a240e0320bee60f77945c6aa1871777306271f96  jian_rev1_default.hex
75d6799419775363e0f1843dd6aa587d7a453883  jian_rev2_default.hex  |     e2a68aad93458a5d0331a0c61e5426a14fd8c1b9  jian_rev2_default.hex
a2cbeb1b15fda1fbc6dcd5e1d41b59f4513507f0  newgame40_default.hex  |     b9c0a5e3c5c04569269bd03407610d16f3df2c38  newgame40_default.hex
df8fa38d555b1f9ca0d2af8b3f5292331c3f1ad0  takashicompany_heavy_left_default.hex   |     aefce6c69dadc6bbd8c906a69203ebb104d315af  takashicompany_heavy_left_default.hex

@fauxpark fauxpark merged commit b1783db into qmk:develop Jun 18, 2023
@fauxpark fauxpark deleted the rgblight-led-count-data-driven branch June 18, 2023 04:39
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@fauxpark @jesperhellberg
Move RGBLED_NUM to data driven (qmk#21278)
1e298f9
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@fauxpark @thismarvin
Move RGBLED_NUM to data driven (qmk#21278)
b643b96
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@fauxpark @akeep
Move RGBLED_NUM to data driven (qmk#21278)
4c80afe
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@fauxpark @csolje
Move RGBLED_NUM to data driven (qmk#21278)
2077d54
@jpskenn jpskenn mentioned this pull request Nov 2, 2023
Open
39 tasks
jpskenn added a commit to jpskenn/qmk_firmware that referenced this pull request Nov 3, 2023
@jpskenn
Move RGBLED_NUM to data driven (qmk#21278)
3772397
jpskenn added a commit to jpskenn/qmk_firmware that referenced this pull request Nov 5, 2023
@jpskenn
Move RGBLED_NUM to data driven (qmk#21278)
abc09f9 
on V031 and V1, RGB Lighting is never enabled ->  remove settings
jashort pushed a commit to jashort/qmk_firmware that referenced this pull request Nov 20, 2023
@fauxpark @jashort
Move RGBLED_NUM to data driven (qmk#21278)
9a6ca01
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@fauxpark @autoferrit
Move RGBLED_NUM to data driven (qmk#21278)
cbf12f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @tzarc