Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PS2_MOUSE_INVERT_BUTTONS #20646

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Fix PS2_MOUSE_INVERT_BUTTONS #20646

merged 2 commits into from
Jul 7, 2023

Conversation

dkao
Copy link
Contributor

@dkao dkao commented Apr 30, 2023

Description

PS2_MOUSE_BTN_RIGHT and PS2_MOUSE_BTN_LEFT are bit positions not bit masks.
Also keep PS2_MOUSE_BTN_MIDDLE

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Apr 30, 2023
@drashna drashna requested a review from a team April 30, 2023 21:54
@zvecr zvecr added the bug label Apr 30, 2023
@drashna drashna requested a review from a team May 9, 2023 06:51
@tzarc tzarc merged commit e430807 into qmk:develop Jul 7, 2023
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@dkao @jesperhellberg
Fix PS2_MOUSE_INVERT_BUTTONS (qmk#20646)
56feb4f
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@dkao @thismarvin
Fix PS2_MOUSE_INVERT_BUTTONS (qmk#20646)
aa05cfc
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@dkao @akeep
Fix PS2_MOUSE_INVERT_BUTTONS (qmk#20646)
4cc3b39
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@dkao @csolje
Fix PS2_MOUSE_INVERT_BUTTONS (qmk#20646)
0a2774c
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@dkao @autoferrit
Fix PS2_MOUSE_INVERT_BUTTONS (qmk#20646)
ed4ecf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkao @drashna @tzarc @zvecr