Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckerBoards G_IDB60 Layout Macro Edits #20596

Merged
merged 6 commits into from
Apr 28, 2023
Merged

CheckerBoards G_IDB60 Layout Macro Edits #20596

merged 6 commits into from
Apr 28, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • adds one new layout macro
  • renames LAYOUT_all to LAYOUT_60_tsangan_hhkb
  • enables Community Layout support
  • edit maintainer value in info.json (reference GitHub username)

cc @npspears (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 27, 2023
@noroadsleft noroadsleft requested a review from a team April 27, 2023 17:08
@drashna drashna requested a review from a team April 27, 2023 20:26
@noroadsleft noroadsleft merged commit 79f21b4 into qmk:develop Apr 28, 2023
@noroadsleft noroadsleft deleted the kb_layouts/checkerboards_g_idb60 branch April 28, 2023 03:44
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
CheckerBoards G_IDB60 Layout Macro Edits (qmk#20596)
6f31bcd 
* add matrix_diagram.md

* info.json: apply friendly formatting

* rename LAYOUT_all to LAYOUT_60_tsangan_hhkb

* add LAYOUT_60_ansi_tsangan

* enable Community Layout support

* info.json: correct maintainer value

Reference the maintainer's GitHub username.
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
CheckerBoards G_IDB60 Layout Macro Edits (qmk#20596)
b0da07d 
* add matrix_diagram.md

* info.json: apply friendly formatting

* rename LAYOUT_all to LAYOUT_60_tsangan_hhkb

* add LAYOUT_60_ansi_tsangan

* enable Community Layout support

* info.json: correct maintainer value

Reference the maintainer's GitHub username.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @fauxpark