Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handwired/dactyl_cc keyboard #20517

Merged
merged 28 commits into from
Jul 3, 2023
Merged

Add handwired/dactyl_cc keyboard #20517

merged 28 commits into from
Jul 3, 2023

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Apr 20, 2023 •
edited
Loading

Description

  • keyboard files added
  • default and via keymaps included

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dunk2k
Added dactyl_cc keyboard
fcc5f0d 
- entry added to `data/mappings/keyboard_aliases.hjson`
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 20, 2023
dunk2k and others added 4 commits April 20, 2023 15:44
@dunk2k
Update readme.md
48ca0d8
@dunk2k
added new line EOF
a53c272
@dunk2k
Update readme.md
c1cb81e
@dunk2k
moved to data driven layout
b091198 
- <kb>.h removed
- `layout` element in `info.json` added with matrices and <kb>.h like labels
@dunk2k dunk2k changed the base branch from develop to master April 21, 2023 14:12
@dunk2k dunk2k changed the base branch from master to develop April 21, 2023 14:13
drashna
drashna requested changes Apr 26, 2023
View reviewed changes
keyboards/handwired/dactyl_cc/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/dactyl_cc/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/dactyl_cc/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/dactyl_cc/readme.md Outdated Show resolved Hide resolved
dunk2k and others added 6 commits April 27, 2023 23:38
@dunk2k @drashna
Update keyboards/handwired/dactyl_cc/readme.md
bf15fd8 
Co-authored-by: Drashna Jaelre <[email protected]>
@dunk2k @drashna
Update keyboards/handwired/dactyl_cc/readme.md
c39b784 
Co-authored-by: Drashna Jaelre <[email protected]>
@dunk2k @drashna
Update keyboards/handwired/dactyl_cc/readme.md
676c4be 
Co-authored-by: Drashna Jaelre <[email protected]>
@dunk2k
Update readme.md
5c058f9 
changed S-1 image to different hosted domain
@dunk2k
Update readme.md
0808c0e 
changed image URL for Ergo S-1
@dunk2k
Update readme.md
f24cb89
@dunk2k dunk2k requested a review from drashna May 7, 2023 17:27
@dunk2k dunk2k changed the title Added dactyl_cc keyboard Add handwired/dactyl_cc keyboard May 7, 2023
drashna
drashna reviewed May 9, 2023
View reviewed changes
keyboards/handwired/dactyl_cc/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/dactyl_cc/config.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team May 9, 2023 07:57
fauxpark
fauxpark requested changes May 9, 2023
View reviewed changes
data/mappings/keyboard_aliases.hjson Outdated Show resolved Hide resolved
keyboards/handwired/dactyl_cc/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/dactyl_cc/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/dactyl_cc/readme.md Outdated Show resolved Hide resolved
@dunk2k dunk2k requested review from drashna and fauxpark May 12, 2023 15:55
drashna
drashna requested changes May 14, 2023
View reviewed changes
keyboards/handwired/dactyl_cc/info.json Outdated Show resolved Hide resolved
@dunk2k dunk2k requested a review from drashna May 14, 2023 12:01
@dunk2k dunk2k mentioned this pull request May 19, 2023
Merged
14 tasks
@dunk2k dunk2k force-pushed the dactylcc_ergoS1 branch from c6b2929 to 921ba75 Compare May 20, 2023 21:22
@drashna drashna merged commit 91fea3a into qmk:develop Jul 3, 2023
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@dunk2k @drashna
@fauxpark @jesperhellberg
[Keyboard] Add dactyl_cc keyboard (qmk#20517)
4c14db8 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
@dunk2k dunk2k deleted the dactylcc_ergoS1 branch September 9, 2023 16:28
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@dunk2k @drashna
@fauxpark @thismarvin
[Keyboard] Add dactyl_cc keyboard (qmk#20517)
683ad6f 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@dunk2k @drashna
@fauxpark @akeep
[Keyboard] Add dactyl_cc keyboard (qmk#20517)
a6c30be 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@dunk2k @drashna
@fauxpark @csolje
[Keyboard] Add dactyl_cc keyboard (qmk#20517)
17ecc88 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
jashort pushed a commit to jashort/qmk_firmware that referenced this pull request Nov 20, 2023
@dunk2k @drashna
@fauxpark @jashort
[Keyboard] Add dactyl_cc keyboard (qmk#20517)
a61e5e3 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@dunk2k @drashna
@fauxpark @autoferrit
[Keyboard] Add dactyl_cc keyboard (qmk#20517)
aae6aad 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
galaxyraiser pushed a commit to galaxyraiser/qmk_firmware that referenced this pull request Oct 6, 2024
@dunk2k @drashna
@fauxpark @galaxyraiser
[Keyboard] Add dactyl_cc keyboard (qmk#20517)
38b8a97 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunk2k @drashna @fauxpark