Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a handful of CLI errors #20321

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Fix a handful of CLI errors #20321

merged 1 commit into from
Apr 3, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Apr 3, 2023

Description

⚠ frobiac/redtilt: Layout "LAYOUT" is offset on Y axis by 1
⚠ skme/zeno: Layout "LAYOUT_default" is offset on Y axis by 0.235

⚠ handwired/tractyl_manuform/5x6_right/arduinomicro: DIODE_DIRECTION in config.h is overwriting diode_direction in info.json
⚠ handwired/tractyl_manuform/5x6_right/elite_c: DIODE_DIRECTION in config.h is overwriting diode_direction in info.json
⚠ handwired/tractyl_manuform/5x6_right/f303: DIODE_DIRECTION in config.h is overwriting diode_direction in info.json
⚠ handwired/tractyl_manuform/5x6_right/f411: DIODE_DIRECTION in config.h is overwriting diode_direction in info.json
⚠ handwired/tractyl_manuform/5x6_right/teensy2pp: DIODE_DIRECTION in config.h is overwriting diode_direction in info.json
⚠ maple_computing/ivy/rev1: DIODE_DIRECTION in config.h is overwriting diode_direction in info.json
⚠ maple_computing/launchpad/rev1: DIODE_DIRECTION in config.h is overwriting diode_direction in info.json
⚠ nightly_boards/n40_o: DIODE_DIRECTION in config.h is overwriting diode_direction in info.json

⚠ lfkeyboards/lfk78/revj: Matrix pins are specified in both info.json and config.h, the config.h values win.

⚠ lily58/r2g: SPLIT_KEYBOARD in rules.mk is overwriting split.enabled in info.json
⚠ lily58/r2g: Feature bootmagic is specified in both info.json and rules.mk, the rules.mk value wins.
⚠ lily58/r2g: Feature oled is specified in both info.json and rules.mk, the rules.mk value wins.
⚠ splitkb/kyria/rev1/proton_c: LTO_ENABLE in rules.mk is overwriting build.lto in info.json
⚠ splitkb/kyria/rev2/proton_c: LTO_ENABLE in rules.mk is overwriting build.lto in info.json

And fixed some duplicate key errors in wt60_h1 and _h3 blocking API update.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team April 3, 2023 05:40
@tzarc tzarc merged commit 2d9140a into qmk:develop Apr 3, 2023
@fauxpark fauxpark deleted the cli-fixes branch April 3, 2023 05:51
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants