-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back default Encoder Callbacks for Keychron Q/V series #20307
Conversation
After some discussion with @drashna over in the QMK Discord, decided to move all of the encoder callbacks into the main |
…ychron-encoder-c
…ychron-encoder-c
…ychron-encoder-c
…ychron-encoder-c
With #20320 merged, is this even relevant? Literally does the same thing as the new |
After come careful consideration, I'm closing this PR due to the existence of #20320. |
Description
After
#18713
, the default encoder callbacks for the encoder variants of the Q2 were removed, and every Q and V board after that followed suit, which became problematic for users of QMK Configurator where after flashing the firmware from there, even with the encoder press working properly (KC_MUTE
), rotation actions never work since as before, the callbacks were removed.This PR is to add them back to rectify this issue to where even in the
QMK Docs
:Types of Changes
Issues Fixed or Closed by This PR
Checklist