Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ortho & numpad layouts to data driven #20183

Merged
merged 28 commits into from
Mar 29, 2023

Conversation

fauxpark
Copy link
Member

Description

All boards with layouts beginning with LAYOUT_ortho_ and LAYOUT_numpad_, including other layouts as consequence.

There will be some SHA mismatches due to tweaks I had to make to certain layouts (eg. Planck) - see #20039.

I also had to skip some boards that use FLIP_HALF to replace the layout macro entirely. Not sure how to handle those...

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark
Copy link
Member Author

Only SHA mismatch is handwired/ortho_brass, which is expected (one of its layouts had a key mapped to two matrix positions). There are other layouts fixed in this way but are clearly unused in the default keymap so will not affect the output.

@fauxpark fauxpark merged commit 4869b80 into qmk:develop Mar 29, 2023
@fauxpark fauxpark deleted the dd-ortho-layouts branch March 29, 2023 04:54
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants