Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix compilation error when defining QUICK_TAP_TERM_PER_KEY #19893

Merged
merged 2 commits into from
Feb 22, 2023
Merged

[Bug] Fix compilation error when defining QUICK_TAP_TERM_PER_KEY #19893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d668a7
Fix compilation error when defining QUICK_TAP_TERM_PER_KEY
precondition Feb 20, 2023
28ac739
Add an explanatory comment to the superfluous QUICK_TAP_TERM_PER_KEY
precondition Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion quantum/action_tapping.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ void action_tapping_process(keyrecord_t record) {
* readable. The conditional definition of tapping_keycode and all the
* conditional uses of it are hidden inside macros named TAP_...
*/
# if (defined(AUTO_SHIFT_ENABLE) && defined(RETRO_SHIFT)) || defined(PERMISSIVE_HOLD_PER_KEY) || defined(QUICK_TAP_TERM_PER_KEY) || defined(HOLD_ON_OTHER_KEY_PRESS_PER_KEY)
# if (defined(AUTO_SHIFT_ENABLE) && defined(RETRO_SHIFT)) || defined(PERMISSIVE_HOLD_PER_KEY) || defined(HOLD_ON_OTHER_KEY_PRESS_PER_KEY)
# define TAP_DEFINE_KEYCODE uint16_t tapping_keycode = get_record_keycode(&tapping_key, false)
# else
# define TAP_DEFINE_KEYCODE
Expand Down
4 changes: 4 additions & 0 deletions tests/tap_hold_configurations/quick_tap/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,7 @@
#include "test_common.h"

#define QUICK_TAP_TERM 100
// Although a seemingly superfluous addition since the default per-key function behaves
// no differently from defining a single global QUICK_TAP_TERM, this has been useful
// to catch compilation errors and prevent regressions in the future; see PR #19893.
#define QUICK_TAP_TERM_PER_KEY