Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for font size with 16 bits height in OLED. (#6650) #19827

Closed
wants to merge 6 commits into from
Closed

Support for font size with 16 bits height in OLED. (#6650) #19827

wants to merge 6 commits into from

Conversation

ngs-ch
Copy link
Contributor

@ngs-ch ngs-ch commented Feb 12, 2023

Description

Supports font display of 16 bits in height on OLED. (24 and 32 also supported, not tested)
Narrowed and extracted only the OLED_FONT_HEIGHT (and OLED_FONT_WIDTH) setting from p-r #13233 and added bug fixes.

Also, because the height is more than 2 bytes, the second line becomes the third byte, and the existing "oled_set_cursor" function cannot specify a cursor on the second byte. Therefore, the "oled_set_cursor_raw" function has been added.

About fonts

In the case of 16 dots high and 12 dots wide, the upper half of a character is 12 bytes, and the lower half of a character is 12 bytes immediately after, making every 24 bytes a character.

About font files

The existing font is enlarged to 200%.

  • The letters and pictograms (up to 0x7F) and OS icons are 200%.
  • The QMK logo is not resized, only adjusted to the center of the height.

The file was created using a modified version of the QMK Logo Editor, which is also featured in the document. I will send the p-r to them as soon as this p-r is merged.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Feb 12, 2023
@drashna drashna requested review from sigprof and a team March 7, 2023 18:10
@github-actions
Copy link

github-actions bot commented May 6, 2023

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label May 6, 2023
@ngs-ch
Copy link
Contributor Author

ngs-ch commented May 27, 2023

I have fixed it, how do you like it?

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label May 28, 2023
zts added a commit to zts/qmk_firmware that referenced this pull request Jun 17, 2023
@zts
Attempt to improve oled layer status readability
4f2bdcf 
The font on the oled displays is very small, and can't be easily
increased at the moment. When the following PR merges, I'll take another
look at this. qmk#19827

Until then, this change removes some duplication/boilerplate, and makes
it a little easier to differentiate the layers at a glance.
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 12, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@sigprof sigprof Awaiting requested review from sigprof

Assignees
No one assigned
Labels
core stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngs-ch @drashna