-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stray UNUSED_PINS #19639
Merged
Merged
Remove stray UNUSED_PINS #19639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
reviewed
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These boards too:
ferris/0_1
(UNUSED_MCU
/UNUSED_MCP
)
ferris/0_2
ingrained
yushakobo/navpad/10/rev0
(UNUSED_PIN
)
yushakobo/navpad/10/rev1
yushakobo/navpad/10_helix_r
No lint checks for those, but they are now gone too. |
fauxpark
approved these changes
Jan 20, 2023
omikronik
pushed a commit
to omikronik/qmk_firmware
that referenced
this pull request
Jan 22, 2023
ideas32
pushed a commit
to ideas32/qmk_firmware
that referenced
this pull request
Jan 25, 2023
tacahiroy
pushed a commit
to tacahiroy/qmk_firmware
that referenced
this pull request
Feb 7, 2023
4pplet
added a commit
to 4pplet/qmk_firmware
that referenced
this pull request
Feb 12, 2023
commit 50f1654 Author: 4pplet <[email protected]> Date: Wed Feb 8 21:34:20 2023 +0100 Update keymap.c commit eac1e66 Author: 4pplet <[email protected]> Date: Wed Feb 8 21:33:50 2023 +0100 fixed canon keymap commit f251483 Author: 4pplet <[email protected]> Date: Wed Feb 8 16:20:57 2023 +0100 adding default layouts and a dedicated canon typewriter layout adding default layouts and a dedicated canon typewriter layout commit 4d1b113 Merge: 8cc98c7 17409da Author: 4pplet <[email protected]> Date: Fri Feb 3 22:58:24 2023 +0100 Merge remote-tracking branch 'upstream/master' into steezy60_rev_b_adding_layouts commit 17409da Author: QMK Bot <[email protected]> Date: Thu Feb 2 18:14:26 2023 -0800 Format code according to conventions (qmk#19739) commit 4d09bfa Author: nendezkombet <[email protected]> Date: Fri Feb 3 09:04:47 2023 +0700 [Keyboard] Add keebformom ortho 4x10 (qmk#18104) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: jack <[email protected]> commit c3406eb Author: zhol0777 <[email protected]> Date: Thu Feb 2 17:00:38 2023 -0800 [Keyboard] Add mkh studio bully (qmk#19696) commit 87c4152 Author: Albert Y <[email protected]> Date: Fri Feb 3 08:17:05 2023 +0800 Update handedness by define examples (qmk#19687) commit 8e9d109 Author: Kassandra Karan <[email protected]> Date: Thu Feb 2 19:14:54 2023 -0500 Added MacOS Support for BigKnob (qmk#19693) commit de6a6f9 Author: lalalademaxiya1 <[email protected]> Date: Fri Feb 3 05:34:39 2023 +0800 [Keyboard] Add Keychron V6 (qmk#19498) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 10c3b97 Author: lalalademaxiya1 <[email protected]> Date: Fri Feb 3 05:34:18 2023 +0800 [Keyboard] Add Keychron V10 (qmk#19504) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit a76e70c Author: lalalademaxiya1 <[email protected]> Date: Fri Feb 3 05:33:56 2023 +0800 [Keyboard] Add rev_0131 for Keychron Q0 (qmk#19547) Co-authored-by: Ryan <[email protected]> commit d3b00d9 Author: TommyZ <[email protected]> Date: Fri Feb 3 05:33:31 2023 +0800 [Keyboard] Add Quarkeys Z67 with solder and hotswap versions (qmk#19465) Co-authored-by: Joel Challis <[email protected]> Co-authored-by: jack <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 3115cdf Author: Andrew Kannan <[email protected]> Date: Thu Feb 2 16:32:22 2023 -0500 [Keyboard] Add Crin (qmk#18065) Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Nick Brassel <[email protected]> commit eeadbd2 Author: Nick Brassel <[email protected]> Date: Fri Feb 3 07:14:26 2023 +1100 Politely ask people not to submit issues to add support for unknown keyboards. (qmk#19737) commit f7e6963 Author: ziptyze <[email protected]> Date: Thu Feb 2 13:17:10 2023 -0500 adding pi60 (qmk#19431) * updates to 1up product line Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: jack <[email protected]> commit 8dc6686 Author: adiabatic <[email protected]> Date: Wed Feb 1 10:55:12 2023 -0800 zweihander-macos: Update keys, add capslock (qmk#19730) * Update to current Scroll Lock/Power names * Replace `'` with `⇪` commit ca8b4b8 Author: a_marmot <[email protected]> Date: Wed Feb 1 09:26:37 2023 -0800 [Keyboard] Add modded Razer Orbweaver with RP2040 (qmk#19711) Co-authored-by: jack <[email protected]> Co-authored-by: Sergey Vlasov <[email protected]> commit 252b041 Author: Patryk <[email protected]> Date: Wed Feb 1 14:13:18 2023 +0000 add Mecx Labs mp1 macropad (qmk#19064) * add mecxlabs mp1 macropad Co-authored-by: Joel Challis <[email protected]> commit e296d67 Author: Nick Brassel <[email protected]> Date: Mon Jan 30 19:47:46 2023 +1100 Accumulate version.h generator flags. (qmk#19716) commit 2c878b1 Author: Ryan <[email protected]> Date: Mon Jan 30 14:37:02 2023 +1100 Clean up `qmk generate-autocorrect-data` (qmk#19710) commit 328279a Author: Wolf Van Herreweghe <[email protected]> Date: Sun Jan 29 23:58:07 2023 +0100 Add base firmware for the Frog Numpad (qmk#19698) Co-authored-by: Wolf Van Herreweghe <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: jack <[email protected]> commit d322b4c Author: yiancar <[email protected]> Date: Sun Jan 29 16:59:13 2023 +0000 [Keyboard] Baion 808 (qmk#19690) Co-authored-by: jack <[email protected]> Co-authored-by: Joel Challis <[email protected]> Co-authored-by: yiancar <[email protected]> commit 981f3c3 Author: Albert Y <[email protected]> Date: Sun Jan 29 00:41:50 2023 +0800 Additional handedness by EEPROM examples (qmk#19686) Co-authored-by: jack <[email protected]> Co-authored-by: Dasky <[email protected]> commit ce7bb63 Author: azhizhinov <[email protected]> Date: Sat Jan 28 01:52:05 2023 +0300 VIA keymap for Reviung 34. (qmk#19694) VIA keymap for Reviung 34. commit acea06b Author: adophoxia <[email protected]> Date: Fri Jan 27 13:39:38 2023 -0800 [Keyboard] Update effects for Keychron Q2 (qmk#19685) commit 9aaf1c2 Author: Patrick Muldoon <[email protected]> Date: Fri Jan 27 08:35:26 2023 -0800 Swap LED_PIN_ON_STATE to 0. (qmk#19692) User reported that CAPS lock Led state was inverted after soldering a LED to their board. LED_PIN_ON_STATE defaults to 1, so just swap to low. Flashed board and now CAPS LED reflects the actual state commit b3dca4b Author: Jay Greco <[email protected]> Date: Fri Jan 27 00:03:57 2023 -0800 Add RP2040 SCRAMBLE v2 (qmk#19489) commit 6e42b58 Author: AnotherStranger <[email protected]> Date: Thu Jan 26 22:14:34 2023 +0100 VIA keymap for the dactyl manuform 4x6 (qmk#19668) Co-authored-by: adophoxia <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> commit 19ecd69 Author: Charly Delay <[email protected]> Date: Fri Jan 27 03:43:08 2023 +0900 Rename `LAYOUT` macros identifier that contained the keyboard name (qmk#19657) commit 3823046 Author: schwarzer-geiger <[email protected]> Date: Thu Jan 26 11:34:27 2023 -0500 new keyboard: edinburgh41 (qmk#19569) * added edinburgh41 Co-authored-by: Joel Challis <[email protected]> Co-authored-by: jack <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> commit fa132ba Author: Darkhan <[email protected]> Date: Wed Jan 25 00:19:32 2023 +0000 Decrease LED animation frequency to improve performance (qmk#19677) commit 8af8720 Author: Christian Brauner <[email protected]> Date: Tue Jan 24 21:03:05 2023 +0100 [Keymap] Update brauner preonic layout (qmk#19665) commit 419a794 Author: arrowj <[email protected]> Date: Tue Jan 24 09:17:24 2023 -0600 Update understanding_qmk.md (qmk#19664) Changed "...4 row by 5 column numpad" to "...5 row by 4 column numpad" on line 46. commit b24fa2f Author: Natan-P <[email protected]> Date: Tue Jan 24 15:19:34 2023 +0100 escaped stray backslash in bux.py (qmk#19667) commit 1c69682 Author: MJM <[email protected]> Date: Tue Jan 24 04:19:42 2023 -0500 [Keyboard] Add the Black Hellebore (qmk#19655) commit 695c4c6 Author: adophoxia <[email protected]> Date: Tue Jan 24 00:51:45 2023 -0800 [Keyboard] Add missing `dip_switch_update_kb` for Keychron V2 (qmk#19674) commit 4d180c9 Author: jack <[email protected]> Date: Tue Jan 24 01:04:56 2023 -0700 fixup splitkb/kyria VIA keymap (qmk#19676) commit 4c6415d Author: cole smith <[email protected]> Date: Mon Jan 23 21:42:38 2023 -0800 [Keyboard] Fix boardsource/lulu/avr encoder pins (qmk#19672) commit 4e658d4 Author: youturn45 <[email protected]> Date: Mon Jan 23 05:23:00 2023 -0500 [Keymap] Add youturn/yt keymap for think65 (qmk#19300) Co-authored-by: jack <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Jue Liu <[email protected]> commit 9c7490d Author: Joe Scotto <[email protected]> Date: Mon Jan 23 04:38:22 2023 -0500 [Keyboard] Add Scotto40 Keyboard (qmk#18453) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: James Young <[email protected]> commit 300a0de Author: era <[email protected]> Date: Sat Jan 21 04:43:11 2023 +0900 Change era65 keymap&debounce_type (qmk#19627) commit 64c399b Author: leah-splitkb <[email protected]> Date: Fri Jan 20 12:22:53 2023 +0100 [Keyboard] Add Kyria rev3 (qmk#19423) commit 53cc617 Author: Joel Challis <[email protected]> Date: Fri Jan 20 05:44:05 2023 +0000 Refactor some layouts which contain keyboard name (qmk#19645) * Refactor some layouts which contain keyboard name * use planck_mit commit 18d107b Author: dztech <[email protected]> Date: Fri Jan 20 12:29:48 2023 +0800 Og60 fix indicator (qmk#19631) commit 255e138 Author: Leo Deng <[email protected]> Date: Fri Jan 20 12:24:06 2023 +0800 djam add rgb matrix (qmk#19621) commit f2ad3ba Author: Joel Challis <[email protected]> Date: Fri Jan 20 02:36:30 2023 +0000 Refactor some layouts which contain keyboard name (qmk#19643) commit 5e502c3 Author: Joel Challis <[email protected]> Date: Fri Jan 20 02:35:18 2023 +0000 Remove stray UNUSED_PINS (qmk#19639) commit 891780b Author: Joel Challis <[email protected]> Date: Fri Jan 20 01:59:46 2023 +0000 Refactor some layouts which contain keyboard name (qmk#19642) commit e5b36e2 Author: leviport <[email protected]> Date: Thu Jan 19 16:09:11 2023 -0700 Docs: typo fixes in platformdev_blackpill_f4x1.md (qmk#19635) commit 22be519 Author: Nick Brassel <[email protected]> Date: Thu Jan 19 22:30:16 2023 +1100 Minor cleanup to breaking/checklist docs. (qmk#19596) Co-authored-by: Ryan <[email protected]> commit 327f7ee Author: Nick Brassel <[email protected]> Date: Thu Jan 19 12:05:29 2023 +1100 Fixup ChibiOS header inclusion search ordering. (qmk#19623) * Add STM32F446-Nucleo onekey. * Fixup onekey build for F446, all keymaps. * Fixup board inclusion search ordering. commit 17c9388 Author: Nick Brassel <[email protected]> Date: Thu Jan 19 09:36:32 2023 +1100 Allow for wildcard filtering in `qmk mass-compile` (qmk#19625) commit d73ad52 Author: Shandon Anderson <[email protected]> Date: Wed Jan 18 03:55:34 2023 -0500 [Keyboard] Add Mino Plus Keyboard (qmk#19535) Co-authored-by: Shandon Anderson <[email protected]> commit e6ec2bd Author: spbgzh <[email protected]> Date: Wed Jan 18 11:54:20 2023 +0300 [Keyboard] Add tata80 (qmk#19445) Co-authored-by: jack <[email protected]> Co-authored-by: Ryan <[email protected]> commit f5a31fd Author: lukeski14 <[email protected]> Date: Tue Jan 17 20:38:53 2023 -0500 updating productId for via compat (qmk#19611) commit 204ba02 Author: Albert Y <[email protected]> Date: Wed Jan 18 09:22:34 2023 +0800 Use consistent highlight format (qmk#19619) commit eb7a8d9 Author: Albert Y <[email protected]> Date: Wed Jan 18 09:22:19 2023 +0800 Reduce RGB maximum brightness (qmk#19618) commit 737e6bf Author: Albert Y <[email protected]> Date: Wed Jan 18 08:26:16 2023 +0800 Highlight inclusion of extern macro (qmk#19614) commit d907f10 Author: Anton <[email protected]> Date: Tue Jan 17 20:46:33 2023 +0300 [Keymap] Add saph1s keymap for KPrepublic BM80v2 (qmk#19608) Co-authored-by: jack <[email protected]> commit 625e574 Author: QMK Bot <[email protected]> Date: Mon Jan 16 23:39:09 2023 -0800 Format code according to conventions (qmk#19615) commit 9f84b9a Author: Ivan Gromov <[email protected]> Date: Tue Jan 17 09:57:18 2023 +0400 [Keyboard] Add kt3700 (qmk#19432) Co-authored-by: Sergey Vlasov <[email protected]> Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Ryan <[email protected]> commit c6cc104 Author: JW2586 <[email protected]> Date: Tue Jan 17 05:56:37 2023 +0000 [Keyboard] Waterfowl - Updated default keymap (qmk#19438) Co-authored-by: jack <[email protected]> commit 7b795b2 Author: Alabahuy <[email protected]> Date: Tue Jan 17 12:48:44 2023 +0700 [Keyboard] add kamigakushi (qmk#19514) commit 49f3ffa Author: d-floe <[email protected]> Date: Mon Jan 16 22:33:49 2023 -0600 [Keyboard] Add Bubble 75 (qmk#18863) Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> commit 4098ff5 Author: era <[email protected]> Date: Tue Jan 17 10:55:13 2023 +0900 [Keyboard] Add ERA65 (qmk#19591) Co-authored-by: Ryan <[email protected]> commit 465b6a1 Author: Tom Barnes <[email protected]> Date: Mon Jan 16 22:41:52 2023 +0000 Docs/space b cleanup (qmk#19612) * Clean up remaining mentions of the deprecated Space B reset method * cleanup auto_tag.yml that got sucked in commit 2bff00e Author: Pablo Martínez <[email protected]> Date: Mon Jan 16 10:32:43 2023 +0100 Small doc changes (qmk#19601) commit 917d93e Author: Sergey Vlasov <[email protected]> Date: Mon Jan 16 11:52:18 2023 +0300 [Docs] Fix `JOYSTICK_AXIS_COUNT` name in docs (qmk#19605) commit 4f83b67 Author: adiabatic <[email protected]> Date: Mon Jan 16 00:48:41 2023 -0800 [Keymap] Improve Zweihander layout for the Ergodox EZ (qmk#18737) commit fe27e46 Author: Ryan Baker <[email protected]> Date: Sun Jan 15 19:55:30 2023 -0500 [Keyboard] Add rb87 (qmk#19546) commit 44bcde1 Author: Christian Brauner <[email protected]> Date: Sun Jan 15 09:03:27 2023 +0100 [Keymap] Update brauner preonic layout (qmk#19595) commit 2c98e79 Author: jack <[email protected]> Date: Sun Jan 15 01:03:16 2023 -0700 [Keyboard] Fixup gingko65 matrix pins (qmk#19589) commit e7d1b21 Author: jurassic73 <[email protected]> Date: Sat Jan 14 19:58:09 2023 -0800 [Keyboard] Update handwired/split89 to new standard. (qmk#19540) Co-authored-by: James Young <[email protected]> commit 4a53d9c Author: Bastien BALOUP <[email protected]> Date: Sun Jan 15 04:46:13 2023 +0100 [Keymap] Add Bastian-Baloup sofle keymap (qmk#18836) Co-authored-by: Ryan <[email protected]> commit 3f2cbc9 Author: Renegade-Master <[email protected]> Date: Sat Jan 14 02:25:07 2023 +0000 Pr/reorder docker podman check (qmk#19561) commit 9c02b29 Author: gitdrik <[email protected]> Date: Fri Jan 13 23:19:57 2023 +0100 Updates to gitdrik Planck keymap (qmk#19585) commit d196ab5 Author: Duccio <[email protected]> Date: Fri Jan 13 12:08:12 2023 +0100 [bluebell/Swoop] Enable RGB underlight by default (qmk#19501) commit 0de7cce Author: Jens Peter Secher <[email protected]> Date: Fri Jan 13 12:04:16 2023 +0100 [Keyboard] Acacia keyboard (qmk#19532) commit e1feab3 Author: Rucker Machine <[email protected]> Date: Fri Jan 13 03:03:37 2023 -0800 [Keyboard] Add additional layout to RM_Numpad (qmk#19534) Co-authored-by: jason <[email protected]> commit b756c53 Author: jack <[email protected]> Date: Fri Jan 13 03:58:38 2023 -0700 [Docs] Touch up documentation templates & porting keyboard docs (qmk#19573) commit c965243 Author: James Young <[email protected]> Date: Fri Jan 13 02:57:35 2023 -0800 Synth Labs 060 Layout Additions and Fixes (qmk#19575) commit aba0441 Author: James Young <[email protected]> Date: Fri Jan 13 02:55:37 2023 -0800 Teleport Native Layout Implementation Rework (qmk#19576) commit 9a4c7a4 Author: James Young <[email protected]> Date: Thu Jan 12 22:48:50 2023 -0800 Quarkeys Z60 Layout Addtions (qmk#19568) * quarkeys/z60/hotswap: rename LAYOUT to LAYOUT_60_ansi_tsangan_split_rshift * quarkeys/z60/solder: add matrix diagram * quarkeys/z60/solder: rename LAYOUT to LAYOUT_all * quarkeys/z60/solder: add LAYOUT_60_ansi * quarkeys/z60/solder: add LAYOUT_60_ansi_split_bs_rshift * quarkeys/z60/solder: add LAYOUT_60_iso * quarkeys/z60/solder: add LAYOUT_60_iso_split_bs_rshift * quarkeys/z60/solder: add LAYOUT_60_ansi_tsangan * quarkeys/z60/solder: add LAYOUT_60_tsangan_hhkb * quarkeys/z60/solder: add LAYOUT_60_iso_tsangan * quarkeys/z60/solder: enable Community Layout support commit c1aef03 Author: Jonathan Moallem <[email protected]> Date: Fri Jan 13 16:38:50 2023 +1000 Rectified ins/del layout macro ordering of Keychron Q1 ANSI (qmk#19560) commit 0cff636 Author: Tom Barnes <[email protected]> Date: Thu Jan 12 11:29:25 2023 +0000 weact docs patch re "security vulnerability" (qmk#19572) commit 2b5e5d9 Author: Christian Brauner <[email protected]> Date: Thu Jan 12 10:56:12 2023 +0100 [Keymap] Add brauner preonic layout (qmk#19444) commit 62eba54 Author: Ramon Imbao <[email protected]> Date: Thu Jan 12 15:45:08 2023 +0800 [Keyboard] Add Plywrks Ji-Eun (qmk#18276) commit 74d8f16 Author: James Young <[email protected]> Date: Wed Jan 11 14:33:30 2023 -0800 Keychron V3: correct layout data (qmk#19567) * keychron/v3/ansi_encoder: correct layout data * keychron/v3/iso_encoder: correct layout data commit 377f87c Author: James Young <[email protected]> Date: Wed Jan 11 12:50:11 2023 -0800 Keychron V1: correct layout data for ANSI versions (qmk#19558) * keychron/v1/ansi: correct layout data * keychron/v1/ansi_encoder: correct layout data
Ivaan
pushed a commit
to Ivaan/qmk_firmware
that referenced
this pull request
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist