De-duplicate platform detection #19603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
force-pushed
the
feature/dedupe_platform_detection2
branch
from
1ca6e2e to
f5acf6e
Compare
tzarc
approved these changes
Jan 19, 2023
omikronik
pushed a commit
to omikronik/qmk_firmware
that referenced
this pull request
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt 2 after #19545 caused converters to fail.
Avoids logic being in 2 different places, and reducing issues when a new platform is introduced.
info.jsonhaving "platform" already being used for another value, with a somewhat meaningless value, is a shame. That could be reworked at a later date. Ive added to 16598 to cover the case whereqmk info -f json -kb <keyboard> -km <keymap_with_convert_to>shows pre-converted info (incorrect mcu/bootloader/protocol/etc)Types of Changes
Issues Fixed or Closed by This PR
Checklist