Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax converter validation within keymap schema #19544

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Relax converter validation within keymap schema #19544

merged 1 commit into from
Jan 9, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 8, 2023 •
edited
Loading

Description

Explicit validation does little to validate that some converters cannot be applied to all situations.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team January 8, 2023 18:03
@zvecr zvecr changed the title Relax converter within keymap schema Relax converter validation within keymap schema Jan 8, 2023
@zvecr zvecr added the core label Jan 8, 2023
@drashna drashna requested a review from a team January 9, 2023 09:04
@zvecr zvecr merged commit a3ed1b0 into develop Jan 9, 2023
@zvecr zvecr deleted the zvecr-patch-1 branch January 9, 2023 09:23
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
Relax converter within keymap schema (qmk#19544)
88e720f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @drashna