Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor alignment of rgb_breathe_table generator #19403

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 22, 2022

Description

  • add "generated" header comments
  • use generic write function

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command core python labels Dec 22, 2022
@zvecr zvecr requested a review from a team December 22, 2022 17:30
@zvecr zvecr merged commit ab1898e into qmk:master Dec 23, 2022
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jan 2, 2023
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command core python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants