Corrected a GPIO pin on config.h on the jisoo pcb #19396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 361103b.
zvecr
approved these changes
Dec 22, 2022
drashna
approved these changes
Dec 23, 2022
sbhal
pushed a commit
to sbhal/qmk_firmware
that referenced
this pull request
Dec 30, 2022
Co-authored-by: Neil Brian Ramirez <[email protected]> Co-authored-by: Neil Brian Ramirez <[email protected]>
jasonisgraham
pushed a commit
to jasonisgraham/qmk_firmware
that referenced
this pull request
Jan 2, 2023
Co-authored-by: Neil Brian Ramirez <[email protected]> Co-authored-by: Neil Brian Ramirez <[email protected]>
omikronik
pushed a commit
to omikronik/qmk_firmware
that referenced
this pull request
Jan 22, 2023
Co-authored-by: Neil Brian Ramirez <[email protected]> Co-authored-by: Neil Brian Ramirez <[email protected]>
ideas32
pushed a commit
to ideas32/qmk_firmware
that referenced
this pull request
Jan 25, 2023
Co-authored-by: Neil Brian Ramirez <[email protected]> Co-authored-by: Neil Brian Ramirez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I mistakenly put GPIO12 on col1 making col3 activate col1 at the same time. col1 should be GPIO14. I already corrected it and the pcb is now working fine,
Types of Changes
Issues Fixed or Closed by This PR
Checklist