Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Uni change folder location #19326

Merged
merged 4 commits into from
Dec 18, 2022
Merged

The Uni change folder location #19326

merged 4 commits into from
Dec 18, 2022

Conversation

petercpark
Copy link
Contributor

@petercpark petercpark commented Dec 14, 2022

Description

Added a keymap to a keyboard. Then moved the entire keyboard folder into a new "stenokeyboards" folder for organizing future projects by StenoKeyboards.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard moves must go through develop. You might want to submit the keymap addition as a separate PR.

@fauxpark fauxpark changed the base branch from master to develop December 14, 2022 16:43
@petercpark
Copy link
Contributor Author

Keyboard moves must go through develop. You might want to submit the keymap addition as a separate PR.

Okay. Can I make a new commit just deleting the keymap changes? I'll save those for separate PR.

@petercpark petercpark changed the title The Uni add keymap and change folder location The Uni change folder location Dec 14, 2022
@fauxpark
Copy link
Member

There is a merge conflict that needs resolving.

@petercpark
Copy link
Contributor Author

There is a merge conflict that needs resolving.

Can you help me out with this? All I did was change the location of this file, I don't know what the conflict is.

@drashna
Copy link
Member

drashna commented Dec 15, 2022

Assuming that you have the qmk repo set as the upstream remote:

git fetch upstream
git merge upstream/develop

Likely, you'll run into merge conflicts when you do this. When you do, it should tell you how to resolve them, basically. But git status to see which files have conflicts (should be in red).

@petercpark
Copy link
Contributor Author

I believe the conflict is now gone

@drashna drashna requested a review from a team December 17, 2022 19:26
@drashna drashna merged commit 7aa2d79 into qmk:develop Dec 18, 2022
@petercpark petercpark deleted the the-uni-keymap branch December 23, 2022 15:27
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants