Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RP2040] update i2c drivers to reflect peripheral number #19277

Merged
merged 1 commit into from
Dec 11, 2022
Merged

[RP2040] update i2c drivers to reflect peripheral number #19277

merged 1 commit into from
Dec 11, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Dec 9, 2022 •
edited
Loading

Description

depends on ChibiOS/ChibiOS-Contrib#352 (merged!)

RP2040 i2c peripherals are numbered starting from zero, therefore the drivers shall follow the same numbering e.g. I2C0 uses the driver I2CD0. This commit fixes the current miss match.

Also sync ChibiOS-contrib to the latest commit

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@KarlK90 KarlK90 requested a review from sigprof December 9, 2022 10:11
@KarlK90 KarlK90 force-pushed the fix/rp2040-i2c-driver-number branch from f0a7dd5 to dd317b5 Compare December 10, 2022 12:54
@KarlK90
RP2040: update i2c drivers to reflect peripheral number
3afdd96 
RP2040 i2c peripherals are numbered starting from zero, therefore the drivers
shall follow the same numbering e.g. I2C0 uses the driver I2CD0. This commit
fixes the current miss match.
@KarlK90 KarlK90 force-pushed the fix/rp2040-i2c-driver-number branch from dd317b5 to 3afdd96 Compare December 10, 2022 12:58
@KarlK90 KarlK90 marked this pull request as ready for review December 10, 2022 12:59
@KarlK90 KarlK90 requested a review from a team December 10, 2022 13:00
@KarlK90
Copy link
Member Author

KarlK90 commented Dec 10, 2022

Contains update to latest ChibiOS-Contrib state at the time of writing.

@drashna drashna requested a review from a team December 10, 2022 19:25
@KarlK90 KarlK90 merged commit 9dc3f79 into qmk:develop Dec 11, 2022
@KarlK90 KarlK90 deleted the fix/rp2040-i2c-driver-number branch December 11, 2022 13:04
@drashna drashna mentioned this pull request Dec 13, 2022
Merged
9 tasks
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@KarlK90 @omikronik
[RP2040] update i2c drivers to reflect peripheral number (qmk#19277)
aa9a742
@chrishoage chrishoage mentioned this pull request Apr 30, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@sigprof sigprof Awaiting requested review from sigprof

Assignees
No one assigned
Labels
core dependencies documentation keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarlK90 @drashna