Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GMMK Pro][Keymap] Change DEBOUNCE_TYPE to sym_eager_pk to reduce latency #19153

Merged
merged 1 commit into from
Dec 4, 2022
Merged

[GMMK Pro][Keymap] Change DEBOUNCE_TYPE to sym_eager_pk to reduce latency #19153

merged 1 commit into from
Dec 4, 2022

Conversation

andrebrait
Copy link
Contributor

Description

Just changing my debounce type on my keymap and adding my reasoning there.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team November 30, 2022 19:49
@drashna drashna merged commit f32070b into qmk:develop Dec 4, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@andrebrait @elpekenin
[Keymap] Change DEBOUNCE_TYPE to sym_eager_pk to reduce latency (qmk#…
5899233 
…19153)
@andrebrait andrebrait deleted the keymap/andrebrait branch December 19, 2022 20:08
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@andrebrait @omikronik
[Keymap] Change DEBOUNCE_TYPE to sym_eager_pk to reduce latency (qmk#…
1d6dbc5 
…19153)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrebrait @drashna @fauxpark