Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining DD keymap_extras migration #19110

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Remaining DD keymap_extras migration #19110

merged 2 commits into from
Dec 21, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 19, 2022 •
edited
Loading

Description

Depends on #19031.

Attempting to cover the changes in qmk/qmk_configurator#1165.

Converts remaining header files, with dirty script....

TODO:

  • finalise parsing
  • generate header files

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command core python labels Nov 19, 2022
@zvecr zvecr force-pushed the feature/dd_keycode_extras2 branch from 86dbb4f to 1f555dd Compare December 9, 2022 00:55
@github-actions github-actions bot removed the cli qmk cli command label Dec 9, 2022
@zvecr zvecr force-pushed the feature/dd_keycode_extras2 branch from 1f555dd to 3c9e2d2 Compare December 9, 2022 01:32
@github-actions github-actions bot added the cli qmk cli command label Dec 9, 2022
@zvecr zvecr marked this pull request as ready for review December 9, 2022 02:51
@drashna drashna requested a review from a team December 11, 2022 09:16
@drashna drashna requested a review from fauxpark December 14, 2022 20:50
@zvecr zvecr merged commit e5721bb into qmk:develop Dec 21, 2022
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
Remaining DD keymap_extras migration (qmk#19110)
03288bb 
* Parse headers to data

* Regen headers from data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
cli qmk cli command core python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @tzarc