Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend eeconfig kb/user datablock API #19094

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Extend eeconfig kb/user datablock API #19094

merged 2 commits into from
Nov 16, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 16, 2022 •
edited
Loading

Description

Following from #18874, my use case required changes to the introduced functionality to be usable:

  • The ability to check version number
    • exposed indirectly to avoid users manually implementing checks
  • The ability to init to non zero values
    • eeconfig_init_kb could be used however it would write twice

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested review from a team and tzarc November 16, 2022 03:28
@drashna drashna requested a review from a team November 16, 2022 06:56
@tzarc tzarc merged commit 57ac917 into qmk:develop Nov 16, 2022
@zvecr zvecr deleted the feature/extra_eeconfig_api branch November 23, 2022 19:34
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Extend eeconfig kb/user datablock API (qmk#19094)
1da18ad
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@zvecr @elpekenin
Extend eeconfig kb/user datablock API (qmk#19094)
e5163ae
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@zvecr @crembz
Extend eeconfig kb/user datablock API (qmk#19094)
b9c474e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @tzarc