Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup keychron/q6 #19066

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Fixup keychron/q6 #19066

merged 1 commit into from
Nov 13, 2022

Conversation

waffle87
Copy link
Member

Description

  • DRIVER_LED_TOTAL -> RGB_MATRIX_LED_COUNT
  • rgb_matrix_indicators_advanced_user -> rgb_matrix_indicators_advanced_kb

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark merged commit 7901ba4 into qmk:develop Nov 13, 2022
@waffle87 waffle87 deleted the fix/q6 branch November 14, 2022 05:54
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@waffle87 @ramonimbao
Fixup keychron/q6 (qmk#19066)
8927d72
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@waffle87 @elpekenin
Fixup keychron/q6 (qmk#19066)
d05b7fa
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@waffle87 @crembz
Fixup keychron/q6 (qmk#19066)
f3bbc12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @fauxpark @zvecr