Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve LED config parsing error messages #19007

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Improve LED config parsing error messages #19007

merged 2 commits into from
Nov 9, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Nov 8, 2022

Description

Helped me track down some of the recent qmk info complaints regarding g_led_config.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 8, 2022 19:15
zvecr
zvecr reviewed Nov 8, 2022
View reviewed changes
lib/python/qmk/info.py Outdated Show resolved Hide resolved
@zvecr zvecr merged commit d789b4b into qmk:develop Nov 9, 2022
@fauxpark fauxpark deleted the led-config-parse-messages branch November 9, 2022 14:16
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Improve LED config parsing error messages (qmk#19007)
2b5ba5a
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@fauxpark @elpekenin
Improve LED config parsing error messages (qmk#19007)
732c8d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
cli qmk cli command enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @zvecr