Fix jump in mouse_report value when scale changes during cirque get report #18992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Avoid sending the report until the scale matches the x,y delta values. Otherwise when adjusting scale while touchpad is active causes a jump in report values due to the touchData and x,y values using different scales, causing the delta calculation to have an erroneous value
chrishoage
force-pushed
the
hoage/18980-cirque-scale-jump
branch
from
af3a7c1 to
1e396d7
Compare
drashna
approved these changes
Nov 8, 2022
fauxpark
approved these changes
Nov 8, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
elpekenin
pushed a commit
to elpekenin/qmk_firmware
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid sending the report until the scale matches the x,y delta values. Otherwise when adjusting scale while touchpad is active causes a jump in report values due to the touchData and x,y values using different scales, causing the delta calculation to have an erroneous value
I'm happy to adjust the approach as needed. This just seemed the simplest way to ensure the report_x|y delta was using the same scale.
Types of Changes
Issues Fixed or Closed by This PR
Checklist