Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pizzakeyboards/pizza65: fix layouts #18979

Merged
merged 1 commit into from
Nov 8, 2022
Merged

pizzakeyboards/pizza65: fix layouts #18979

merged 1 commit into from
Nov 8, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Nov 7, 2022

Description

☒ pizzakeyboards/pizza65: Number of keys for LAYOUT_65_iso_blocker does not match! info.json specifies 69 keys, C macro specifies 68

Very similar issue to #18974; extra key hiding behind ISO enter. Renamed layouts and keymaps for consistency.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added bug keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 7, 2022
@fauxpark fauxpark requested a review from a team November 7, 2022 00:52
@github-actions github-actions bot removed the via Adds via keymap and/or updates keyboard for via support label Nov 7, 2022
@fauxpark fauxpark merged commit 4b12bd0 into qmk:develop Nov 8, 2022
@fauxpark fauxpark deleted the pizza65-fix-layouts branch November 8, 2022 03:25
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
pizzakeyboards/pizza65: fix layouts (qmk#18979)
b30df72
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@fauxpark @elpekenin
pizzakeyboards/pizza65: fix layouts (qmk#18979)
154af15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
bug keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @zvecr