Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix Tap Toggle functionality #18976

Closed
wants to merge 1 commit into from
Closed

Conversation

drashna
Copy link
Member

@drashna drashna commented Nov 6, 2022

Description

Quick fix of Tap Toggle keycodes due to shifting around.

If the better solution is found ...

For testing, added debugging. This does not work:

> ACT: Keycode 0x52C7, layer 7, code: 0xA7F0

This does:

> ACT: Keycode 0x5307, layer 7, code: 0xA7F0

Action code appears to be the same (and correct). But one works, the other doesn't. prints were placed at the layer_invert spot, so ... if it's printing, it should work, but ...

Moving the location works but isn't great.

Types of Changes

  • Core
  • Bugfix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant