Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED config fixes #18973

Merged
merged 1 commit into from
Nov 11, 2022
Merged

LED config fixes #18973

merged 1 commit into from
Nov 11, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Nov 6, 2022

Description

⚠ handwired/hnah108: led_config: hnah108.c: Unable to parse g_led_config position data

Missing a column of LEDs, and LED count was incorrect. Confirmed with video of PCB on Mechlovin Youtube channel.

⚠ kbdfans/odin/rgb: led_config: rgb.c: Unable to parse g_led_config position data

Removed math expressions and corrected LED count (PCB appears to have 100 keys + 4 logo).

⚠ keybee/keybee65: led_config: keybee65.c: Unable to parse g_led_config position data

Last row seemed to be missing most of the LEDs. No position info available for underglow LEDs, so they were removed for now.

⚠ linworks/fave84h: led_config: fave84h.c: Unable to parse g_led_config position data

No position info available for underglow LEDs, so they were removed for now.

⚠ linworks/fave87h: led_config: fave87h.c: Unable to parse g_led_config position data

No position info available for underglow LEDs, so they were removed for now.

⚠ mechlovin/hannah60rgb/rev2: led_config: rev2.c: Unable to parse g_led_config position data

Added flags and positions (at 0,0) for 8 underglow LEDs.

⚠ melgeek/mj64/rev1: led_config: rev1.c: OOB within g_led_config matrix data

Added missing flags.

⚠ opendeck/32/rev1: led_config: rev1.c: Unable to parse g_led_config position data

Removed macro for calculating positions. Also fixed a missing ).

⚠ ryanskidmore/rskeys100: led_config: rskeys100.c: OOB within g_led_config matrix data

No design files available; renumbered LED indexes to be contiguous and adjusted LED count.

⚠ xelus/dawn60/rev1_qmk: led_config: rev1_qmk.c: Unable to parse g_led_config matrix data

Removed math expressions.

⚠ xelus/pachi/rgb/rev1: led_config: rev1.c: Unable to parse g_led_config matrix data

Removed math expressions.

⚠ xelus/pachi/rgb/rev2: led_config: rev2.c: Unable to parse g_led_config matrix data

Removed math expressions.

cc @Xelus22 @ryanskidmore @vuhopkep @ToastyStoemp @mechlovin @melgeek001365 @cmdremily

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark
Copy link
Member Author

fauxpark commented Nov 6, 2022

CI failures unrelated.

Copy link

@ryanskidmore ryanskidmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for ryanskidmore/rskeys100

@fauxpark
Copy link
Member Author

fauxpark commented Nov 6, 2022

@ryanskidmore and others, would appreciate if you could test these changes, as I don't have any of these boards and in some cases had to make some (not so) educated guesses.

@Xelus22
Copy link
Contributor

Xelus22 commented Nov 6, 2022

LGTM. for my ones. FWIW i made them like that so its easier to calculate the index from row/col.

@tzarc tzarc merged commit 20ed138 into qmk:develop Nov 11, 2022
@fauxpark fauxpark deleted the led-config-fixes branch November 11, 2022 01:21
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants