-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LED config fixes #18973
LED config fixes #18973
Conversation
CI failures unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for ryanskidmore/rskeys100
@ryanskidmore and others, would appreciate if you could test these changes, as I don't have any of these boards and in some cases had to make some (not so) educated guesses. |
LGTM. for my ones. FWIW i made them like that so its easier to calculate the index from row/col. |
Description
Missing a column of LEDs, and LED count was incorrect. Confirmed with video of PCB on Mechlovin Youtube channel.
Removed math expressions and corrected LED count (PCB appears to have 100 keys + 4 logo).
Last row seemed to be missing most of the LEDs. No position info available for underglow LEDs, so they were removed for now.
No position info available for underglow LEDs, so they were removed for now.
No position info available for underglow LEDs, so they were removed for now.
Added flags and positions (at 0,0) for 8 underglow LEDs.
Added missing flags.
Removed macro for calculating positions. Also fixed a missing ).
No design files available; renumbered LED indexes to be contiguous and adjusted LED count.
Removed math expressions.
Removed math expressions.
Removed math expressions.
cc @Xelus22 @ryanskidmore @vuhopkep @ToastyStoemp @mechlovin @melgeek001365 @cmdremily
Types of Changes
Issues Fixed or Closed by This PR
Checklist