Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler.txt: ensure file exists before comparison #18921

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

fauxpark
Copy link
Member

Description

When CC is clang, and compiler.txt does not exist, the following is printed to stderr:

error: write on a pipe with no reader

On macOS at least, this results in false [WARNINGS] when running the unit tests.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 31, 2022 23:06
@github-actions github-actions bot removed the core label Oct 31, 2022
@zvecr zvecr merged commit 7ebc396 into qmk:develop Nov 1, 2022
@fauxpark fauxpark deleted the compiler-txt-check-file-exists branch November 1, 2022 04:45
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants