Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup keebio/sinc/rev3 #18866

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Fixup keebio/sinc/rev3 #18866

merged 1 commit into from
Oct 27, 2022

Conversation

waffle87
Copy link
Member

Description

  • DRIVER_LED_TOTAL -> RGB_MATRIX_LED_COUNT
  • avoid using rgblight config for rgb_matrix

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 27, 2022 06:27
@nooges nooges merged commit a96a9fd into qmk:develop Oct 27, 2022
@waffle87 waffle87 deleted the fix/sinc branch October 27, 2022 20:32
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@waffle87 @ramonimbao
Fixup keebio/sinc/rev3 (qmk#18866)
06b13b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@nooges nooges nooges approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @nooges @fauxpark