Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalise CTPC logic from common_features #18803

Merged
merged 1 commit into from
Oct 22, 2022
Merged

Generalise CTPC logic from common_features #18803

merged 1 commit into from
Oct 22, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 21, 2022 •
edited
Loading

Description

Remove CTPC specific changes, and allow other converters to specify other defaults

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Oct 21, 2022
@zvecr zvecr requested a review from a team October 21, 2022 20:40
@drashna drashna requested a review from a team October 22, 2022 18:38
@drashna drashna merged commit 575db69 into qmk:develop Oct 22, 2022
@zvecr zvecr deleted the feature/post_converter branch November 23, 2022 19:35
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Generalise CTPC logic from common_features (qmk#18803)
a5d6565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark